Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of support for new pagination in TS file #345

Closed
gbar opened this issue Feb 19, 2020 · 1 comment
Closed

Lack of support for new pagination in TS file #345

gbar opened this issue Feb 19, 2020 · 1 comment

Comments

@gbar
Copy link

gbar commented Feb 19, 2020

it would be good to have official TS support for

      if (res.headers.link) {
        const link = parseLinkHeader(res.headers.link);

        if (link.next) {
          Object.defineProperties(data, {
            nextPageParameters: { value: link.next.query }
          });
        }

        if (link.previous) {
          Object.defineProperties(data, {
            previousPageParameters: { value: link.previous.query }
          });
        }
      }

cause now I'm forced to use e.g. orders['nextPageParameters'] or Object.getOwnPropertyDescriptor(orders, 'nextPageParameters')

@lpinca
Copy link
Collaborator

lpinca commented Feb 19, 2020

Already discussed in #288 (comment).

@lpinca lpinca closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants