Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check FSL scripts for branches #9

Open
Lestropie opened this issue Sep 17, 2020 · 1 comment
Open

Check FSL scripts for branches #9

Lestropie opened this issue Sep 17, 2020 · 1 comment

Comments

@Lestropie
Copy link
Member

The current pruning process implicitly assumes that the example data on which the external software scripts are run are sufficient to explore the full set of commands that may be invoked by those scripts. If however there is any branching logic within those scripts that results in a specific command being invoked only in certain circumstances, then it is possible that a command may be pruned that is in fact requisite for certain types of data input.

While such absences should be reported by users over time, it would be preferable to do an initial interrogation of the code within these scripts, and cross-reference with the results of the minify pruning process. If such code branches can be found, then the test data should be augmented to ensure that such commands are utilised at least once during the battery of tests.

@Lestropie
Copy link
Member Author

Note: as an example, 775b803 was necessitated due to a code branch in standard_space_roi, with 5ttgen fsl following different branches depending on use of the -nocrop option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant