Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils.spawn.find_executable to shutil.which #2210

Closed
Lestropie opened this issue Oct 23, 2020 · 2 comments
Closed

distutils.spawn.find_executable to shutil.which #2210

Lestropie opened this issue Oct 23, 2020 · 2 comments
Labels
Milestone

Comments

@Lestropie
Copy link
Member

The MRtrix3 Python API depends on the distutils module for the find_executable() function. Apparently usage of this module is discouraged in favour of setuptools, and it is indeed intended for deprecation. But even then, with setuptools being to "download, build, install, upgrade, and uninstall Python packages", it's not necessarily a sensible dependency to have.

As of Python 3.3, the widely-used shutil module has the which() function, which serves the same purpose.

So if following through with #2047, I would suggest making the minimum dependency 3.3 (released Sep 2012), and making use of this function throughout.

@Lestropie Lestropie added this to the 3.1.0 updates milestone Oct 23, 2020
@bjeurissen
Copy link
Member

Makes sense!

@jdtournier
Copy link
Member

I'd be happy enough this that too. It really should be OK to mandate Python 3.3 by now, but I expect we'll find it'll still cause friction in some cases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants