From 19f3dc9a0560ee85efe52d9be0ec935061d1469b Mon Sep 17 00:00:00 2001
From: Maxime Perrault <166825146+maximeperraultdev@users.noreply.github.com>
Date: Tue, 9 Jul 2024 10:13:00 +0200
Subject: [PATCH] Revert "fix(components): add $ to isHidden"

This reverts commit bcdd45f14c91cd8e385c0d28be659549a91e7687.
---
 src/elements/Label.tsx             | 16 ++++++++--------
 src/fields/CheckPicker.tsx         |  2 +-
 src/fields/MultiCascader/index.tsx |  2 +-
 src/fields/MultiSelect.tsx         |  2 +-
 src/fields/NumberInput.tsx         |  2 +-
 src/fields/PhoneInput.tsx          |  2 +-
 src/fields/Search.tsx              |  2 +-
 src/fields/Select.tsx              |  2 +-
 src/fields/TextInput.tsx           |  2 +-
 src/fields/Textarea.tsx            |  2 +-
 src/fields/Toggle/index.tsx        |  2 +-
 stories/elements/Label.stories.tsx |  4 ++--
 12 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/elements/Label.tsx b/src/elements/Label.tsx
index 8eac78f53..5d6949440 100644
--- a/src/elements/Label.tsx
+++ b/src/elements/Label.tsx
@@ -4,10 +4,10 @@ import styled from 'styled-components'
 import type { LabelHTMLAttributes } from 'react'
 
 export type LabelProps = LabelHTMLAttributes<HTMLLabelElement> & {
-  $isHidden?: boolean | undefined
   $isRequired?: boolean | undefined
   disabled?: boolean | undefined
   hasError?: boolean | undefined
+  isHidden?: boolean | undefined
 }
 export const Label = styled.label.attrs<LabelProps, LabelProps>(props => ({
   className: classnames('Element-Label', props.className)
@@ -26,13 +26,13 @@ export const Label = styled.label.attrs<LabelProps, LabelProps>(props => ({
         color: ${p.theme.color.maximumRed};
       }`}
   ${p =>
-    p.$isHidden &&
+    p.isHidden &&
     `
-    position:absolute;
-    left:-10000px;
-    top:auto;
-    width:1px;
-    height:1px;
-    overflow:hidden;
+  position:absolute;
+  left:-10000px;
+  top:auto;
+  width:1px;
+  height:1px;
+  overflow:hidden;
     `}
 `
diff --git a/src/fields/CheckPicker.tsx b/src/fields/CheckPicker.tsx
index d6b2e1187..3f3f657df 100644
--- a/src/fields/CheckPicker.tsx
+++ b/src/fields/CheckPicker.tsx
@@ -127,7 +127,7 @@ export function CheckPicker<OptionValue extends OptionValueType = string>({
 
   return (
     <Field className={controlledClassName} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/MultiCascader/index.tsx b/src/fields/MultiCascader/index.tsx
index db5a0132c..31595d528 100644
--- a/src/fields/MultiCascader/index.tsx
+++ b/src/fields/MultiCascader/index.tsx
@@ -100,7 +100,7 @@ export function MultiCascader<OptionValue extends OptionValueType = string>({
 
   return (
     <Field className={controlledClassName} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/MultiSelect.tsx b/src/fields/MultiSelect.tsx
index 4b38e0e5f..5c9feb8bb 100644
--- a/src/fields/MultiSelect.tsx
+++ b/src/fields/MultiSelect.tsx
@@ -128,7 +128,7 @@ export function MultiSelect<OptionValue extends OptionValueType = string>({
 
   return (
     <Field className={controlledClassName} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/NumberInput.tsx b/src/fields/NumberInput.tsx
index 01302a829..8ce692781 100644
--- a/src/fields/NumberInput.tsx
+++ b/src/fields/NumberInput.tsx
@@ -105,7 +105,7 @@ export function NumberInput({
 
   return (
     <Field className={controlledClassname} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/PhoneInput.tsx b/src/fields/PhoneInput.tsx
index 9c6df9a07..42f6d7f5b 100644
--- a/src/fields/PhoneInput.tsx
+++ b/src/fields/PhoneInput.tsx
@@ -63,7 +63,7 @@ export const PhoneInput = forwardRef<HTMLInputElement, PhoneInputProps>(
 
     return (
       <Field className="Field-PhoneInput">
-        <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={name}>
+        <Label $isRequired={isRequired} disabled={disabled} htmlFor={name} isHidden={isLabelHidden}>
           {label}
         </Label>
         <StyledIMaskInput
diff --git a/src/fields/Search.tsx b/src/fields/Search.tsx
index 43821e87b..6ce3f4d3e 100644
--- a/src/fields/Search.tsx
+++ b/src/fields/Search.tsx
@@ -187,7 +187,7 @@ export function Search<OptionValue extends OptionValueType = string>({
 
   return (
     <Field className={controlledClassName} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/Select.tsx b/src/fields/Select.tsx
index cd5f658c9..f5bbafaf0 100644
--- a/src/fields/Select.tsx
+++ b/src/fields/Select.tsx
@@ -141,7 +141,7 @@ export function Select<OptionValue extends OptionValueType = string>({
 
   return (
     <Field className={controlledClassname} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/TextInput.tsx b/src/fields/TextInput.tsx
index f468b3607..9b6a3dec4 100644
--- a/src/fields/TextInput.tsx
+++ b/src/fields/TextInput.tsx
@@ -86,7 +86,7 @@ export function TextInput({
 
   return (
     <Field className={controlledClassname} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/Textarea.tsx b/src/fields/Textarea.tsx
index 486596592..4882fa770 100644
--- a/src/fields/Textarea.tsx
+++ b/src/fields/Textarea.tsx
@@ -77,7 +77,7 @@ export function Textarea({
 
   return (
     <Field className={controlledClassname} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name} isHidden={isLabelHidden}>
         {label}
       </Label>
 
diff --git a/src/fields/Toggle/index.tsx b/src/fields/Toggle/index.tsx
index 83152409f..e68dabbbe 100644
--- a/src/fields/Toggle/index.tsx
+++ b/src/fields/Toggle/index.tsx
@@ -59,7 +59,7 @@ export function Toggle({
 
   return (
     <Field className={controlledClassName} style={style}>
-      <Label $isHidden={isLabelHidden} $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name}>
+      <Label $isRequired={isRequired} disabled={disabled} htmlFor={originalProps.name} isHidden={isLabelHidden}>
         {label}
       </Label>
       <StyledToggle
diff --git a/stories/elements/Label.stories.tsx b/stories/elements/Label.stories.tsx
index 85ae09b70..f93f7fb76 100644
--- a/stories/elements/Label.stories.tsx
+++ b/stories/elements/Label.stories.tsx
@@ -6,10 +6,10 @@ import type { LabelProps } from '../../src'
 import type { Meta } from '@storybook/react'
 
 const args: LabelProps = {
-  $isHidden: false,
   $isRequired: false,
   children: 'A form input label',
-  disabled: false
+  disabled: false,
+  isHidden: false
 }
 
 /* eslint-disable sort-keys-fix/sort-keys-fix */