Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jester is not working correctly #2

Closed
Ougawa opened this issue Dec 15, 2020 · 12 comments
Closed

Jester is not working correctly #2

Ougawa opened this issue Dec 15, 2020 · 12 comments
Assignees

Comments

@Ougawa
Copy link

Ougawa commented Dec 15, 2020

Hello !
I've tried your mod with a bunch of friends, we managed to make it working but it seems like Jester can't win the game.
We tested multiple games to try if we can make him win. When he is being voted during an emergency, the game still continue.
In the console, we can see that "Jester has won"
https://cdn.discordapp.com/attachments/772170650898923584/788542838878896148/unknown.png
But the game doesn't stop, and no matter what we're doing (finishing all tasks, voting imposter, or imposter killing everyone) there is no way where we have the Jester screen at the end.

I supposed that you wanted to end the game when Jester wins, but for me and my group it's not working at all.
Is there a solution for it,
Thank you

@Maartii
Copy link
Owner

Maartii commented Dec 16, 2020

Thanks for opening an issue here!

Something strange is going one here, and I'm not entirely sure yet what, since for me it works fine somehow. I'll try to fix it as soon as possible though.

@Maartii Maartii self-assigned this Dec 16, 2020
@Maartii Maartii pinned this issue Dec 16, 2020
@Ougawa
Copy link
Author

Ougawa commented Dec 16, 2020

Is there a way for me to give you informations to help you find what's the problem?
It's pretty weird if that works for you and not for us. I mean, we just added the mod on the plugin folder of Impostor, i don't think there is anything else to do for the mod to work? (We've put last version of Impostor and we've tried 2 different releases of your Jester mod)

@celsosa
Copy link

celsosa commented Dec 16, 2020

Same problem here, tested on 1.0.1 and 1.1.0 :/

@Maartii
Copy link
Owner

Maartii commented Dec 17, 2020

@Ougawa @celsosa
Tried to fix the issue. Could you maybe try to use the new version of the plugin (1.1.1) with the latest experimental version of the Impostor server? (current version is 1.2.2-ci.123, you can find it at https://ci.appveyor.com/project/Impostor/Impostor/branch/dev/artifacts)

Hope everything will be running smoothly for you now, please let me know how it goes if you decide to try it.

@Maartii
Copy link
Owner

Maartii commented Dec 17, 2020

@Ougawa

Your way of installing the mod was correct by the way, you only have to drop it into the plugin folder of Impostor.

@RobinRMC
Copy link

Same issue for me.

@Ougawa
Copy link
Author

Ougawa commented Dec 18, 2020

I'm gonna try soon as i can your fix Maartii.

Same issue for me.

Did you try his fix he sent me ?

@Maartii
Copy link
Owner

Maartii commented Dec 18, 2020

@RobinRMC
Just to verify, were you using the new version of the plugin with the latest experimental build of the Impostor server?

@Ougawa
Copy link
Author

Ougawa commented Dec 18, 2020

I've just tried with my group, and seems like it's working now!
I'm gonna send you more if i see some bugs

@Maartii
Copy link
Owner

Maartii commented Dec 19, 2020

Thanks, good to know! Happy to hear it works now. Would be glad to hear if there are any bugs.

@Maartii Maartii closed this as completed Dec 19, 2020
@celsosa
Copy link

celsosa commented Dec 19, 2020

@Ougawa @celsosa
Tried to fix the issue. Could you maybe try to use the new version of the plugin (1.1.1) with the latest experimental version of the Impostor server? (current version is 1.2.2-ci.123, you can find it at https://ci.appveyor.com/project/Impostor/Impostor/branch/dev/artifacts)

Hope everything will be running smoothly for you now, please let me know how it goes if you decide to try it.

Now it works, thanks ^-^ (btw, did u update the source code? Cause I want to compile the plugin translatade, so my friends can understand the game mode )

@Maartii
Copy link
Owner

Maartii commented Dec 19, 2020

Now it works, thanks ^-^ (btw, did u update the source code? Cause I want to compile the plugin translatade, so my friends can understand the game mode )

Glad to hear it works. Yep, I updated the source code as well. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants