Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce should increment client side in any case request makes it past authentication guard on server #84

Open
Ian-Bright opened this issue Jul 27, 2024 · 0 comments

Comments

@Ian-Bright
Copy link
Member

In the cli controllers we only increment a nonce locally if the an http request returns with a "200" code. Really what should be done is we should increment the nonce if we make it past the guard on the server as the nonce will always be incremented server side in this case. We do have the synchronize nonce function to handle the nonce mismatch but it may be better to handle this on http response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant