New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints #387

Open

Yrlish opened this issue Nov 10, 2018 · 1 comment

Yrlish commented Nov 10, 2018 •

edited

Loading

Hi there!

I would really appreciate if the methods were defined with correct return data type as specified in PEP-484.

This would help with typing hints where the IDE can correctly determine how to help out with the right methods and variables.

Some examples on places I've stumbled into this:

create_ppol should type hint Pool
Pool.acquire() should type hint Connection
Connection.fetch() should type hint list of Record
Connection.fetchrow() should type hint Record or None

The text was updated successfully, but these errors were encountered:

Member

elprans commented Nov 28, 2018

@Yrlish PRs are welcome!

dsluo mentioned this issue

Add type hints #487

Closed

Yrlish mentioned this issue

Make PoolAcquireContext return a Connection type #578

Open

bryanforbes mentioned this issue

Add typings #577

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment