Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the UX of search box #519

Closed
Sven-TBD opened this issue Jan 8, 2024 · 13 comments
Closed

Enhance the UX of search box #519

Sven-TBD opened this issue Jan 8, 2024 · 13 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sven-TBD
Copy link
Contributor

Sven-TBD commented Jan 8, 2024

Search box will show all of result by different types together, and the "by Name" and "by ID" are no longer a necessary option but just a location where the specific type is.

Image

@Sven-TBD Sven-TBD self-assigned this Jan 8, 2024
@Sven-TBD Sven-TBD added the enhancement New feature or request label Jan 8, 2024
@Sven-TBD
Copy link
Contributor Author

Sven-TBD commented Feb 5, 2024

PRD:https://vs0cjf.axshare.com/?id=908ssd&g=14&p=%E6%90%9C%E7%B4%A2%E4%BC%98%E5%8C%96%E8%AF%B4%E6%98%8E&sc=3

BTW,A Not Found Page is also needed when there is no result while searching a String without click on the dropbox.

@Keith-CY
Copy link
Member

Keith-CY commented Apr 7, 2024

How is it going @PainterPuppets

@rabbitz
Copy link

rabbitz commented Apr 16, 2024

nervosnetwork/ckb-explorer#1790

# single_query
GET /api/v1/suggest_queries?q=?

# aggregate_query
GET /api/v1/suggest_queries?q=?&filter_by=0

image

@Sven-TBD
Copy link
Contributor Author

@PainterPuppets How‘s it going with this feature

@PainterPuppets
Copy link

@PainterPuppets How‘s it going with this feature

Just noticed that the backend is ready, I'll start working on this issue today and expect it to take 2 days

@Keith-CY
Copy link
Member

@PainterPuppets How‘s it going with this feature

Just noticed that the backend is ready, I'll start working on this issue today and expect it to take 2 days

How is it going

@PainterPuppets
Copy link

nervosnetwork/ckb-explorer#1790

# single_query
GET /api/v1/suggest_queries?q=?

# aggregate_query
GET /api/v1/suggest_queries?q=?&filter_by=0

image

Hi @rabbitz
I noticed that the search currently returns token_collection type data, but there's no typehash field in the return data, so there's no way to make a jump
Do we have any plans to add the this fields?

image

@rabbitz
Copy link

rabbitz commented May 9, 2024

@PainterPuppets

nervosnetwork/ckb-explorer#1838

Field sn was added to token collection response.

@PainterPuppets
Copy link

@PainterPuppets

nervosnetwork/ckb-explorer#1838

Field sn was added to token collection response.

Accessing https://testnet-api.explorer.nervos.org/api/v1/suggest_queries?q=Spore&filter_by=0 doesn't seem to have the sn field returned, which url should I use?

@Keith-CY
Copy link
Member

@PainterPuppets
nervosnetwork/ckb-explorer#1838
Field sn was added to token collection response.

Accessing testnet-api.explorer.nervos.org/api/v1/suggest_queries?q=Spore&filter_by=0 doesn't seem to have the sn field returned, which url should I use?

Please check this @rabbitz

@PainterPuppets
Copy link

Hi @rabbitz
There are some search keywords that do not seem to have any results at the moment, like:

Btc address: tb1qwq82nch2wc0jtymavfv2cxsju9trghn0ykhqx8
image

BTC Tx :4ea970151577aff9f134bd50ce666d304c979f8d204c4fa8f4cd0a1bf7c3bbd1
image

.bit did: test.bit
image

Can you check it out for me?

@Keith-CY
Copy link
Member

Hi @rabbitz There are some search keywords that do not seem to have any results at the moment, like:

Btc address: tb1qwq82nch2wc0jtymavfv2cxsju9trghn0ykhqx8 image

BTC Tx :4ea970151577aff9f134bd50ce666d304c979f8d204c4fa8f4cd0a1bf7c3bbd1 image

.bit did: test.bit image

Can you check it out for me?

.bit was not supported in the backend, so it's calling .bit indexer directly at https://github.com/nervosnetwork/ckb-explorer-frontend/blob/develop/src/components/Search/index.tsx#L218-L227

@FrederLu
Copy link

Verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

6 participants