Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-latest for packaging #123

Closed
Keith-CY opened this issue Apr 4, 2023 · 3 comments
Closed

Use macos-latest for packaging #123

Keith-CY opened this issue Apr 4, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Apr 4, 2023

macos-11 was specified by nervosnetwork/neuron@4275a3d because macos-latest was randomly assigned to macos-11 or macos-12, and these two environments have different dependencies, it would be difficult to fit these two.

Now macos-latest is assigned to macos-12 and we can update the workflow for it
image

@Keith-CY Keith-CY added the enhancement New feature or request label Apr 4, 2023
@Keith-CY Keith-CY added this to Neuron Apr 4, 2023
@Keith-CY Keith-CY moved this to 🆕 New in Neuron Apr 4, 2023
@Danie0918 Danie0918 moved this from 🆕 New to 📌Planning in Neuron Apr 10, 2023
@Danie0918 Danie0918 assigned WhiteMinds and unassigned Danie0918 Apr 20, 2023
@Danie0918 Danie0918 moved this from 📌Planning to 🏗 In Progress in Neuron Apr 20, 2023
@WhiteMinds
Copy link

I simply replaced "macos-11" with "macos-latest" in nervosnetwork/neuron@5b7f4cd, and everything seems to be working fine based on the current results: https://github.com/nervosnetwork/neuron/actions/runs/4899407459.

I'm not sure what happened before, but I think maybe the issue has been resolved by this pull request: nervosnetwork/neuron#2627.
@Keith-CY, could you provide more information to supplement?

@Keith-CY
Copy link
Member Author

Keith-CY commented May 6, 2023

I simply replaced "macos-11" with "macos-latest" in nervosnetwork/neuron@5b7f4cd, and everything seems to be working fine based on the current results: nervosnetwork/neuron/actions/runs/4899407459.

I'm not sure what happened before, but I think maybe the issue has been resolved by this pull request: nervosnetwork/neuron#2627. @Keith-CY, could you provide more information to supplement?

It's fixed by upgrading electron-builder from 22.14.5(https://github.com/nervosnetwork/neuron/blob/4275a3de3a5ba623de33dfc48052f75a532b1590/packages/neuron-wallet/package.json#L86) to 23.6.0(https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/package.json#L87)


It was a hotfix(nervosnetwork/neuron@4275a3d) during release(nervosnetwork/neuron#2627) by degrading macos-latest to macos-11 because python2, which is required by [email protected], was removed from macos-12. And at that time, the reliance to python2 was fixed in [email protected](electron-userland/electron-builder#6606 (comment)).

Then we have 3 options:

  1. upgrade electron-builder to 23.0.2
  2. introduce python2 into github runner manually
  3. set macos-11 explicitly

Because it was during a release, option 1 was not acceptable.
Because python2 will not be relied on in future versions, option 2 was not worth it.

So option 3 was taken as a hotfix.

@WhiteMinds
Copy link

It seems that i just need to revert the previous changes.

PR: nervosnetwork/neuron#2664

@Danie0918 Danie0918 assigned Keith-CY and unassigned WhiteMinds May 15, 2023
@Danie0918 Danie0918 moved this from 🏗 In Progress to 👀 Testing in Neuron May 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 Testing to ✅ Done in Neuron May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants