Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Compatibility-Windows】CKB node needs specific version of Microsoft VC++ Redistributable to run,but the pop up window does not show which VC++ versions are available. #263

Closed
silySuper opened this issue Aug 10, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@silySuper
Copy link

For example:
1.After I installed this version,app still shows install VC++ pop up window.
image
image
2.But if I installed this version ,it is OK,not pop up window.
image

In my opinion,to help user easier to use this app,it is better to indicate which VC++ versions are available.

@silySuper silySuper added the enhancement New feature or request label Aug 10, 2023
@Danie0918 Danie0918 assigned yanguoyu and unassigned Danie0918 Aug 11, 2023
@yanguoyu
Copy link

@Keith-CY Does the VC++ Redistributable have a minimum version requirement for ckb?
@Danie0918 How to more clear notice to users?

@Keith-CY
Copy link
Member

@Keith-CY Does the VC++ Redistributable have a minimum version requirement for ckb? @Danie0918 How to more clear notice to users?

It's specified neither in CKB release note nor in Download from release. But a link in Download from release points to Visual C++ Redistributable for Visual Studio 2015

@yanguoyu
Copy link

https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170 The title is Microsoft Visual C++ Redistributable latest supported downloads, Should we notice the users to download the latest version from https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022? @Danie0918 @Keith-CY

image

@Danie0918
Copy link
Contributor

Danie0918 commented Aug 11, 2023

@Keith-CY Does the VC++ Redistributable have a minimum version requirement for ckb? @Danie0918 How to more clear notice to users?

Add minimum version requirements, if any.


By the way,I had this doubt before, but solved it by downloading the latest version. But this is always a threshold for users, as C++ is not a component that comes with the system, can we get rid of this dependency?

@Danie0918
Copy link
Contributor

https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170 The title is Microsoft Visual C++ Redistributable latest supported downloads, Should we notice the users to download the latest version from https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022? @Danie0918 @Keith-CY

image

Downloading the latest version is the most versatile option.

@yanguoyu
Copy link

@Keith-CY Does the VC++ Redistributable have a minimum version requirement for ckb? @Danie0918 How to more clear notice to users?

Add minimum version requirements, if any.

By the way,I had this doubt before, but solved it by downloading the latest version. But this is always a threshold for users, as C++ is not a component that comes with the system, can we get rid of this dependency?

Should we replace https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170 with https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022? Or by another way to tell users to download the latest version?

@Danie0918
Copy link
Contributor

@Keith-CY Does the VC++ Redistributable have a minimum version requirement for ckb? @Danie0918 How to more clear notice to users?

Add minimum version requirements, if any.
By the way,I had this doubt before, but solved it by downloading the latest version. But this is always a threshold for users, as C++ is not a component that comes with the system, can we get rid of this dependency?

Should we replace https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170 with https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022? Or by another way to tell users to download the latest version?

The two links above will point to the same page, so replacing the links is unnecessary and we need to tweak the prompt text.

[Text-en]The network nodes in Neuron rely on C++ components, so please install the latest version of Microsoft Visual C++Redistributable for x64 to ensure that the software runs properly.

[Text-cn]Neuron 中的网络节点依赖C++组件,请安装 x64 最新版本的 Microsoft Visual C++Redistributable 来保证软件正常运行。

@yanguoyu
Copy link

@yanguoyu yanguoyu assigned silySuper and unassigned yanguoyu Aug 11, 2023
@silySuper
Copy link
Author

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants