Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBADMIN redirect ignores host port #419

Closed
Greek64 opened this issue Mar 21, 2018 · 5 comments
Closed

WEBADMIN redirect ignores host port #419

Greek64 opened this issue Mar 21, 2018 · 5 comments

Comments

@Greek64
Copy link

Greek64 commented Mar 21, 2018

If I bind the http port of the front container to some non standard port (e.g. localhost:8080), the admin container originating 301 redirects ignore the original requested port in their Location header.

Say front is listening to localhost:8080.
An access to "localhost:8080/admin" results in a correct redirect to "localhost:8080/admin/ui", originating from the nginx proxy in front.
An access to "localhost:8080/admin/ui" results in a incorrect redirect to "http://localhost/admin/ui/", which originates from the admin container. (Port 8080 is ignored in the redirect response)

I tried to find the source of the issue, but I have zero flask/python experience.

@kaiyou
Copy link
Member

kaiyou commented Mar 21, 2018

I remember fixing this a couple weeks ago, which version are you running currently?

@kaiyou kaiyou added the bug label Mar 21, 2018
@Greek64
Copy link
Author

Greek64 commented Mar 22, 2018

Oh, I'm running 1.5.
Forgot to check the master before submitting the issue.
Let me check.

@Greek64
Copy link
Author

Greek64 commented Mar 22, 2018

So I tested it now with the updated 1.5 branch, and the master.
The problem still exists on both.

@Greek64
Copy link
Author

Greek64 commented Mar 27, 2018

Correction on the last one.
I tried master again, and the redirect problem is fixed.
My browser probably cached something wrong the last time I tested it.
Since that is the case, I'm closing this issue.

Sorry for the inconvenience.

@Greek64 Greek64 closed this as completed Mar 27, 2018
@Greek64
Copy link
Author

Greek64 commented Mar 27, 2018

Will the fix be ported back to 1.5?
I'm not fond of running on the latest/master branch.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants