Email visibility option

[Lan2u]

We don't consistently mask or not users emails.

Proposal:
As a makespace member I want to choose if my email should be visible to other makespace members so I have control over who can contact me.

As an admin/super-user I want to be able to see all emails used by makespace members so I can send emails about important/safety issues in line with our privacy policy.

[Lan2u]

@chromy @erkannt thoughts on this one? Perhaps we should always mask for non-admins but sometimes I do want to message people privately / let them message me

[erkannt]

I like that. 'Show my email to other members' toggle?

[chromy]

@Lan2u @erkannt For me I would be in favour of just always showing emails to Makespace members - although I admit I just put my email out in public which not everyone likes to do.

If we continue hide them there are some complicated edge cases to worry about.
Like probably trainers need to be able to see peoples emails on the equipment page if they've filled the form?
Otherwise it's hard to do the manual reconciliation / searching for misfiled forms.

As an alternative we could take the emails off the '/members' page but leave them on '/member/1234' etc that way there not all in a single giant list.

Also concerned that bugs like the one linked above will continue to occur till either it's built into the read model somehow (like emails are redacted at the point of fetching data depending on the actor doing the fetching or something) or we give up on hiding them.

[Lan2u]

emails are redacted at the point of fetching data depending on the actor doing the fetching or something) or we give up on hiding them.

I think something of this type will probably be needed eventually anyway. We kinda have the same problem with all read models where we need to do isSuperUser or isTrainer etc. i.e. when getting equipment

[Lan2u]

Assigning myself for an initial first pass (mvp) as part of #47

[chromy]

Tried pushing the permissions back to the read model like this: 58fa478 let me know you thoughts.

[erkannt]

I like pulling this into read models. Keep renderers stupid and moves us toward once and only once for this concern.