-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CairoMakie: Marker Rotation is not exported (scatter) #1465
Comments
Hm weird, CairoMakie needs a set_theme!()
xtimes = 10
x = repeat([1],xtimes)
y = range(0,5,length=xtimes) |> collect
rot = range(0,stop=π*2,length=xtimes) |> collect
fg = scatter(x,y,rotations=rot,marker='↑') |
so GLMakie accepts both From a user perspective it happened multiple times that I misspell something, but get no error, and then wonder why something doesnt work - I understand that parsing this is hard because one doesnt exactly know what all the possible targets are - you are probably aware of it. The changing the glyph-size automatically in GLMakie always confused me, I see a plot more like a painting ;) But I agree, consistency would be nice here |
Well GLMakie uses quads to draw glyphs on, and these quads are by default all the same size. To get an unsquare quad and thereby correct glyph aspect ratio, one would have to take the additional step of querying glyph size, which I've always found quite undesirable for end users. So CairoMakie does that automatically, I've kind of treated GLMakie behavior like a bug in that way, which might have been a bit drastic. Unknown keywords should error in future refactors of plot types, right now attribute collections are just dumb dictionaries, you can put anything in them as long as noone asks |
This seems to still be an issue on CairoMakie v0.10.7 |
Fixed in Makie 0.21 via #3724 |
Minimal example
With GLMakie
With CairoMakie
Clearly CairoMakie should have rotated the arrows as well
In earlier versions of CairoMakie glyphs drawn with
annotations
did work with rotations, but havent tested it yet.PS: The different markersizes are surely reported somewhere (?), a bit annoying to work with...
PPS: Great work as always!
The text was updated successfully, but these errors were encountered: