Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CairoMakie does not respect the z translation of plots inside recipes #2792

Closed
asinghvi17 opened this issue Mar 21, 2023 · 0 comments · Fixed by #2793
Closed

CairoMakie does not respect the z translation of plots inside recipes #2792

asinghvi17 opened this issue Mar 21, 2023 · 0 comments · Fixed by #2793
Assignees
Labels
CairoMakie This relates to CairoMakie, the vector backend for Makie based on Cairo.

Comments

@asinghvi17
Copy link
Member

Encountered this recently in a custom recipe (basically a choropleth which shows all admin levels (states, regions, districts) of a specific country. This is because we don't fully flatten plots in CairoMakie, instead relying on recipe level implementations. Thus, any z-level adjustment that is not at the level of the plot which sits in scene.plots will not be applied.

The solution to this is to change how get_all_plots behaves, such that it fully flattens all plots to the atomic level. Then, it could be overridden by multiple dispatch for certain plot types, like band or poly, which we want to be able to plot directly.

These recipe overrides would also have to detect whether their components had the same transformation matrices, and figure out how to handle them if they do not.

@asinghvi17 asinghvi17 added the CairoMakie This relates to CairoMakie, the vector backend for Makie based on Cairo. label Mar 21, 2023
@asinghvi17 asinghvi17 self-assigned this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CairoMakie This relates to CairoMakie, the vector backend for Makie based on Cairo.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant