Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc builds are failing on quite a few PRs #2823

Closed
asinghvi17 opened this issue Mar 30, 2023 · 2 comments
Closed

Doc builds are failing on quite a few PRs #2823

asinghvi17 opened this issue Mar 30, 2023 · 2 comments
Labels
CI Continous Integration

Comments

@asinghvi17
Copy link
Member

I've seen this in #2811, #2822, and #2818.

→ evaluating code [example_8731089[887](https://github.com/MakieOrg/Makie.jl/actions/runs/4562075546/jobs/8048980920?pr=2811#step:6:888)802825557] in (tutorials/scenes.md)        Killed

is the last line of the error. Is it possible that we're hitting some kind of time or rate limit on Github Actions?
@asinghvi17 asinghvi17 added the CI Continous Integration label Mar 30, 2023
@SimonDanisch
Copy link
Member

Ah hm -.- I think that's because record_states in the new JSServe version treats the sliders as dependent, leading to many more states to record, taking forever to render out...Although on my pc it was somewhat ok (a minute or so?), but who knows how long CI will take ^^

@SimonDanisch
Copy link
Member

Fixed in #2428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continous Integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonDanisch @asinghvi17