Remove plural from rotations attribute?

[c42f]

I just got caught out because the rotations attribute to scatter is pluralized, in contrast to pretty much all the other attributes. Can we rename this to rotation?

Are there other attributes which should also have the plural removed? How do we find them all?

[SimonDanisch]

Hm, maybe it needs to be marker_rotation, since there is also a rotation default keyword for all plots, translating into a rotation of the whole plot!

[c42f]

Ah, that's awkward 😬 So some attributes relate to the plot as a whole and others the elements which are to be plotted. Of course this makes sense and is a bit unavoidable if we want convenient plotting in a single function call.

But wait... the following doesn't seem to do anything:

scatter([1,2], [1,2], rotation=1)

is that right?

[SimonDanisch]

No :-D maybe need to go through this, make it consistent and have some tests^^

[yakir12]

Also, to rotate text you need to specify rotation in singular, yet another reason to standardize.

[ffreyer]

Fixed in 0.21 via #3724