-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jk/tex gyre heros #1897
Merged
Merged
jk/tex gyre heros #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrumbiegel
force-pushed
the
jk/tex-gyre-heros
branch
from
May 8, 2022 18:06
2c43a48
to
4e2a7ab
Compare
SimonDanisch
approved these changes
May 9, 2022
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. using time
This PR does not change the using time. ttfp time
This PR does not change the ttfp time. |
jkrumbiegel
force-pushed
the
jk/tex-gyre-heros
branch
from
May 16, 2022 12:33
4e2a7ab
to
61bb0e9
Compare
kunzaatko
pushed a commit
to kunzaatko/Makie.jl
that referenced
this pull request
May 16, 2022
* add edited tex gyre heros makie fonts * change title defaults to bold * change font in layout tutorial * add news entry * fix test against floating point inaccuracy
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds four fonts to Makie, TeX Gyre Heros Regular, Bold, Italic and Bold Italic. It also sets the default font to Heros Regular. TeX Gyre Heros is a free Arial / Helvetica lookalike.
These fonts are not exactly the originals from https://ctan.org/pkg/tex-gyre-heros but slightly modified with www.glyphrstudio.com. The issue with the original fonts was that they have an unusually high ascender which causes problems with vertical centering, default line heights and boundingbox sizes. Our current logic determines glyph boundingboxes from font descender to ascender. Therefore, characters are centered too low visually if the ascender is very large. Rather than overhaul the whole layout system to deal with these peculiarities, it seemed simpler to just create modified fonts that have less extreme descenders and ascenders. I set the descender to the small g extent and the ascender to the mirror of that above the cap height of M. That naturally centers the font correctly for numbers when centering with the boundingbox and generally looks good in legends as well.
Also I set the titles to bold font because that tends to be easier to parse visually in facet plots and in the future, subtitles should be optional and both title and subtitle in regular font looks bad.