-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the appliance console file a class that we can run #8
Comments
This issue has been automatically marked as stale because it has not been updated for at least 6 months. If you can still reproduce this issue on the current release or on Thank you for all your contributions! |
I think this is good in theory, and has been a concern for over 4 years. Extracting the actual work into separate command pattern objects seemed to be the least amount of work. This has the benefit of being smaller steps, easier to test, and being used from the appliance console cli. I admit, I had dreams of adding a web interface to these commands many moons ago, but think I am over it now. |
@carbonin is this still a valid issue? If yes, please remove the stale label. If not can you close. |
Yeah, I think this is still a valid RFE. |
Thanks @carbonin |
Right now the console is a big script which is run when it is required.
We would rather make it a class or module that has a
.run
method which can take parameters instead of relying on environment variables such asRAILS_ROOT
.This issue was moved to this repository from ManageIQ/manageiq-gems-pending#12, originally opened by @carbonin
The text was updated successfully, but these errors were encountered: