Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify an MSRV policy #90

Closed
tertsdiepraam opened this issue May 29, 2024 · 2 comments · Fixed by #91
Closed

Specify an MSRV policy #90

tertsdiepraam opened this issue May 29, 2024 · 2 comments · Fixed by #91

Comments

@tertsdiepraam
Copy link

Hi! We depend on this library in domain transitively via moka and just got bit by new requirement that rust 1.76 or later should be used. This is fine of course, but I wanted to ask if you could specify some MSRV policy or provide the rust-version key in Cargo.toml, which will help prevent issues like this once the MSRV-dependent resolver lands.

@Manishearth
Copy link
Owner

Sounds good, I'll add the rust-version key. I don't really plan on maintaining any MSRV between semver-compat releases, but it doesn't hurt to have the metadata in the Cargo.toml!

@tertsdiepraam
Copy link
Author

Not wanting to maintain a policy is very understandable. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants