-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace proj strings by EPSG code in CRS definition #649
Comments
Parsing the code for "+proj" reveals a couple of other locations. Can we replace these ones, too? The remaining ones in the projection wizard are not easy to replace. I can take care of these in another ticket. |
Please look for my comment in the PR! |
I will take a look
@wthaem In my first test with windows it seems to be fine, and the delay related to #647 has disappeared. So it seems that we have made some progress. I still want to do some more tests on another pc, and let's wait what @Phobooky says. |
Excuse me, but I didn't realize there was a new build. I just tested and the problem has been resolved. I attach the log in which you can see that there is no longer a delay. Thank you so much.
|
Ok, I will wait with reviewing the PR. |
It's a shame, but we have a side effect from the last build. #652 |
Is your feature request related to a problem? Please describe.
From GDAL >= 3 / PROJ >= 6 PROJ strings to encode CRS should be considered as a a legacy solution. Using a AUTHORITY:CODE or WKT representation is the recommended way.
In the QMS code there are still some proj strings that can be easily replaced.
Describe the solution you'd like
Replace proj strings by EPSG code in these files:
src/qmapshack/map/CMapTMS.cpp
src/qmapshack/map/CMapGEMF.cpp
src/qmapshack/grid/CProjWizard.cpp
src/qmaptool/overlay/refmap/CProjWizard.cpp
Describe alternatives you've considered
none
Give a reason why someone else should spend time on that request
I will do a PR
Additional context
Related to #647, although it is not clear that this will solve the problem. That's the reason for a separate issue that can be closed independently of the resolution for #647
The text was updated successfully, but these errors were encountered: