Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proj strings by EPSG code in CRS definition #649

Open
mitxel-m opened this issue Dec 5, 2023 · 6 comments
Open

Replace proj strings by EPSG code in CRS definition #649

mitxel-m opened this issue Dec 5, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@mitxel-m
Copy link
Contributor

mitxel-m commented Dec 5, 2023

Is your feature request related to a problem? Please describe.

From GDAL >= 3 / PROJ >= 6 PROJ strings to encode CRS should be considered as a a legacy solution. Using a AUTHORITY:CODE or WKT representation is the recommended way.

In the QMS code there are still some proj strings that can be easily replaced.

Describe the solution you'd like

Replace proj strings by EPSG code in these files:
src/qmapshack/map/CMapTMS.cpp
src/qmapshack/map/CMapGEMF.cpp
src/qmapshack/grid/CProjWizard.cpp
src/qmaptool/overlay/refmap/CProjWizard.cpp

Describe alternatives you've considered

none

Give a reason why someone else should spend time on that request

I will do a PR

Additional context

Related to #647, although it is not clear that this will solve the problem. That's the reason for a separate issue that can be closed independently of the resolution for #647

@kiozen
Copy link
Collaborator

kiozen commented Dec 6, 2023

Parsing the code for "+proj" reveals a couple of other locations. Can we replace these ones, too? The remaining ones in the projection wizard are not easy to replace. I can take care of these in another ticket.

@wthaem
Copy link
Contributor

wthaem commented Dec 6, 2023

Please look for my comment in the PR!

@mitxel-m
Copy link
Contributor Author

mitxel-m commented Dec 7, 2023

Parsing the code for "+proj" reveals a couple of other locations. Can we replace these ones, too? The remaining ones in the projection wizard are not easy to replace. I can take care of these in another ticket.

I will take a look

Please look for my comment in the PR!

@wthaem In my first test with windows it seems to be fine, and the delay related to #647 has disappeared. So it seems that we have made some progress. I still want to do some more tests on another pc, and let's wait what @Phobooky says.

@Phobooky
Copy link

Phobooky commented Dec 7, 2023

Excuse me, but I didn't realize there was a new build. I just tested and the problem has been resolved. I attach the log in which you can see that there is no longer a delay. Thank you so much.

2023-12-07 11:23:35.927 [debug] ------------------------------
2023-12-07 11:23:35.927 [debug] TMS: try to open "W:/QMapShack/CARTO/Maps/WMTS-TMS/OpenStreetMap.tms"
2023-12-07 11:23:35.933 [debug] Create projection: "+proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m +nadgrids=@null +wktext +no_defs +type=crs" -> "EPSG:4326"
2023-12-07 11:23:35.933 [debug] tms: "+proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m +nadgrids=@null +wktext +no_defs +type=crs"
2023-12-07 11:23:35.961 [debug] ------------------------------

@kiozen
Copy link
Collaborator

kiozen commented Dec 7, 2023

Parsing the code for "+proj" reveals a couple of other locations. Can we replace these ones, too? The remaining ones in the projection wizard are not easy to replace. I can take care of these in another ticket.

I will take a look

Ok, I will wait with reviewing the PR.

@Phobooky
Copy link

Phobooky commented Dec 7, 2023

It's a shame, but we have a side effect from the last build. #652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants