Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning The punycode module is deprecated. Please use a userland alternative instead. #2485

Open
kaixin-hc opened this issue Mar 30, 2024 · 1 comment

Comments

@kaixin-hc
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

Tell us about your environment

M2 Mac v13.6

MarkBind version

5.4.0

Describe the bug and the steps to reproduce it

When running markbind serve -d
Screenshot 2024-03-30 at 2 15 48 PM
(node:2418) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.

This is also flagged if you npm run test and read through the logs.

Expected behavior

We shouldn't get a deprecation error.

Anything else?

I don't think this is an issue with (most) of markbind things, but rather something from node. My node version is Node.js v21.7.1 . See this issue on yarn...

The History section of DEP0040 in the Node.js documentation shows that Node.js punycode has been deprecated since Node.js v7.0.0 in Oct 2016 and, starting with Node.js v21.0.0, this has been changed to a runtime deprecation (see nodejs/node#47202). The runtime deprecation is what has caused it to now become visible.

Potential options:

  • We might decide not to do anything about this, it doesn't affect functionality yet
  • Switch to node LTS version, which apparently does not have this error
  • ?

Aside from node, it seems punycode is also a dependency for tough-cookie and two others> Not sure if we can move away from this.

@gerteck
Copy link
Contributor

gerteck commented Aug 19, 2024

Some light investigation:

  • I can reproduce this issue when using Node v21.7.3.
  • For Node v20.16.0, there isn't this issue.

This issue probably will have to be addressed or taken note at some point in the future when Node is updated to Node 22 or 24, given the stance to change it to a runtime depreciation from v21 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants