-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformer RenameKeywords Incorrectly convert to lower case name when Library is first #199
Comments
Thank you for the report - I was able to reproduce it and also fix locally. I will push fix soon. |
There is case with "RPA" where whole string should stay uppercase. Maybe in future whitelist for substrings |
I have similar case for Library name issues |
I think I will just ignore library part - so only keyword part (after last '.') is capitalized. For example: But Rpa.Keyword -> Rpa.Keyword (since we don't change library part). Then it could be improved in the future if we will get module for recognizing libraries from pythonpath. |
The alternative is that I can try to at least title case every part of the name: RPA.Browser.playwright.Take Screenshot -> splits into RPA, Browser, playwright, Take Screenshot. playwright -> Playwright and rest stays without change. |
I think is nice solution for now, but in future I see other cases in some keywords project will use some abbreviations. where ABC and DFG are part that should stay uppercase This make it a little more complex. |
I've reworked it a bit to just uppercase first letter of every words, so parts like ABC stays ABC (and not Abc). |
I have tested this version its great way to format old code :) |
Related to #194
Transformer RenameKeywords Incorrectly convert to lower case name when Library is first
For case when ex. Library is first like this case Process. will incorrectly convert "Run" to "run"
Process.Run Process -> Process.run Process
RPA.Browser.Playwright.Take Screenshot -> Rpa.browser.playwright.take Screenshot
The text was updated successfully, but these errors were encountered: