Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PINS_DEBUGGING (M43) gets error when compiling #16647

Closed
maukcc opened this issue Jan 22, 2020 · 4 comments
Closed

[BUG] PINS_DEBUGGING (M43) gets error when compiling #16647

maukcc opened this issue Jan 22, 2020 · 4 comments

Comments

@maukcc
Copy link
Contributor

maukcc commented Jan 22, 2020

Bug Description

If PINS_DEBUGGING is defined, and any serial port other then 0 is chosen, we get the following error when compiling:

sketch/src/gcode/config/../../pins/pinsDebug.h:142:9: error: 'RXD_NAME_0' was not declared in this scope
{ RXD_NAME_0, 0, true },
^
sketch/src/gcode/config/../../pins/pinsDebug.h:143:9: error: 'TXD_NAME_0' was not declared in this scope
{ TXD_NAME_0, 1, true },

My Configurations

bugfix-2.0.x
#define MOTHERBOARD BOARD_CNCONTROLS_15D

@maukcc maukcc changed the title [BUG] (short description) [BUG] PINS_DEBUGGING (M43) gets error when compiling Jan 22, 2020
@ellensp
Copy link
Contributor

ellensp commented Jan 22, 2020

Managed to reproduce, that is odd... I know that code used to work... just testing a fix.

@ellensp
Copy link
Contributor

ellensp commented Jan 22, 2020

Issue is SERIAL_PORT_2 code is being compiled in when its not defined in Configuration.h, SERIAL_PORT_2 defaults to serial0 so expects 'RXD_NAME_0 and 'TXD_NAME_0 to be defined. Breaks when SERIAL_PORT is anything but 0. The fix is ready, just waiting for it to be merged.

@ellensp
Copy link
Contributor

ellensp commented Jan 26, 2020

This has been fixed and added to bugfix-2.0.x

@boelle boelle closed this as completed Jan 26, 2020
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants