Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] #16818 seems to corrupt communication #16838

Closed
GMagician opened this issue Feb 11, 2020 · 5 comments
Closed

[BUG] #16818 seems to corrupt communication #16838

GMagician opened this issue Feb 11, 2020 · 5 comments

Comments

@GMagician
Copy link
Contributor

It seems that above reported PR corrupt all communications. I'm investigating
@GMagician
Copy link
Contributor Author

GMagician commented Feb 11, 2020 •
edited
Loading

Well well well well, it seems that each gcode line is seen twice
so 'line number is not last line number+1' error is sent

Tomorrow I'll investigate what is generated by compiler...

@vivian-ng
Copy link
Contributor

Will this affect printing from SD card? I have been trying to start a print from the SD card after flashing with latest bugfix-2.0.x, but the printer seems to just do nothing.

@vivian-ng
Copy link
Contributor

I reset to before the commit for PR#16818 and can now start a print from SD card. Seems like the commit from PR#16818 onward may have some code that affects how gcode is read. Hopefully someone with better knowledge of how the PR was implemented (like @thinkyhead ) can shed some light.

@GMagician
Copy link
Contributor Author

GMagician commented Feb 12, 2020 •
edited
Loading

@vivian-ng yes it may affect also sd printing. Common code. This evening I'm gonna check it

@GMagician GMagician mentioned this issue Feb 12, 2020
Merged
@TheMath38 TheMath38 mentioned this issue Apr 10, 2020
Closed
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GMagician @vivian-ng