Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.4.4 #16992

Closed
shawnp30 opened this issue Feb 26, 2020 · 17 comments
Closed

2.0.4.4 #16992

shawnp30 opened this issue Feb 26, 2020 · 17 comments

Comments

@shawnp30
Copy link

using btt gtr v1.0 with 2.0.4.4 when enabling sdcard support i get errors with sd card string. when i disable eeprom and sd card supoort marlin compiles
image

@szepnorbee
Copy link

+1 with BOARD_BTT_SKR_V1_3

@GMagician
Copy link
Contributor

Try bugfix

@GMagician
Copy link
Contributor

#16990 duplicate

@shawnp30
Copy link
Author

tried bug fix still error

@freeasabeer
Copy link

In file queue.cpp line 530, replace MSG_SD_ERR_READ by STR_SD_ERR_READ

@lesstutrey
Copy link

freeasabeer that sort of works.. but just leads to new compile errors in planner.cpp so..

@freeasabeer
Copy link

Not on my side: melzi_optiboot with Creality Ender 3 configuration, the build ends successfully with the fix I proposed.

@oscar6502
Copy link

freeasabeer, works for me, thanks!

@wkelley70
Copy link

In file queue.cpp line 530, replace MSG_SD_ERR_READ by STR_SD_ERR_READ

Worked for me with a BTT SKR 1.3. Thanks.

@thisiskeithb
Copy link
Member

This has been fixed in bugfix-2.0.x:

if (n < 0 && !card_eof) { SERIAL_ERROR_MSG(STR_SD_ERR_READ); continue; }

@Scope666
Copy link

This has been fixed in bugfix-2.0.x:

if (n < 0 && !card_eof) { SERIAL_ERROR_MSG(STR_SD_ERR_READ); continue; }

New error after applying this fix:

Marlin\src\module\planner.cpp: In static member function 'static bool Planner::_populate_block(block_t*, bool, const abce_long_t&, const xyze_pos_t&, feedRate_t, uint8_t, const float&)':
Marlin\src\module\planner.cpp:2407:19: error: 'maxj' was not declared in this scope
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                   ^~~~
Marlin\src\module\planner.cpp:2407:19: note: suggested alternative: 'fmaxl'
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                   ^~~~
                   fmaxl
Marlin\src\module\planner.cpp:2407:36: error: 'axis' was not declared in this scope
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                                    ^~~~
Marlin\src\module\planner.cpp:2407:36: note: suggested alternative: 'exit'
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                                    ^~~~
                                    exit
Marlin\src\module\planner.cpp:2396:23: warning: unused variable 'extra_xyjerk' [-Wunused-variable]
       constexpr float extra_xyjerk = 0;
                       ^~~~~~~~~~~~
Compiling .pio\build\LPC1768\src\src\module\servo.cpp.o
Compiling .pio\build\LPC1768\src\src\module\stepper.cpp.o
*** [.pio\build\LPC1768\src\src\module\planner.cpp.o] Error 1

@Kokorone
Copy link

Kokorone commented Feb 27, 2020

This has been fixed in bugfix-2.0.x:

if (n < 0 && !card_eof) { SERIAL_ERROR_MSG(STR_SD_ERR_READ); continue; }

New error after applying this fix:

Marlin\src\module\planner.cpp: In static member function 'static bool Planner::_populate_block(block_t*, bool, const abce_long_t&, const xyze_pos_t&, feedRate_t, uint8_t, const float&)':
Marlin\src\module\planner.cpp:2407:19: error: 'maxj' was not declared in this scope
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                   ^~~~
Marlin\src\module\planner.cpp:2407:19: note: suggested alternative: 'fmaxl'
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                   ^~~~
                   fmaxl
Marlin\src\module\planner.cpp:2407:36: error: 'axis' was not declared in this scope
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                                    ^~~~
Marlin\src\module\planner.cpp:2407:36: note: suggested alternative: 'exit'
                   maxj = (max_jerk[axis]          // mj : The max jerk setting for this axis
                                    ^~~~
                                    exit
Marlin\src\module\planner.cpp:2396:23: warning: unused variable 'extra_xyjerk' [-Wunused-variable]
       constexpr float extra_xyjerk = 0;
                       ^~~~~~~~~~~~
Compiling .pio\build\LPC1768\src\src\module\servo.cpp.o
Compiling .pio\build\LPC1768\src\src\module\stepper.cpp.o
*** [.pio\build\LPC1768\src\src\module\planner.cpp.o] Error 1

I have this bug already submitted under this issue link. It only occurs when you have CLASSIC_JERK enabled

https://github.com/MarlinFirmware/Marlin/issues/16991

@zonalimitatore
Copy link

In file queue.cpp line 530, replace MSG_SD_ERR_READ by STR_SD_ERR_READ

Thanks.Work on atmega gt2560

@Danielstc91
Copy link

In file queue.cpp line 530, replace MSG_SD_ERR_READ by STR_SD_ERR_READ

Also worked for me with BTT SKR 1.3.

@thinkyhead
Copy link
Member

Thanks for the report. Adding an automated test for EEPROM off with SD on.

@wmmc01
Copy link

wmmc01 commented Mar 2, 2020

This: In file queue.cpp line 530, replace MSG_SD_ERR_READ by STR_SD_ERR_READ, also fixed the error for the BTT SKR V1.4 Turbo!

@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests