[FR] WIP: MKS UI/TFT_LVGL_UI Updates & Fixes #18476

thisiskeithb · 2020-06-30T19:21:50Z

Bug Description

This is a continuation of discussion from PR #18438. Several issues still exist:

To-do

Upgrade to LVGL 7.x

Complete

Rename TFT_LITTLE_VGL_UI to TFT_LVGL_UI since it was renamed to LVGL - "Light and Versatile Graphics Library" in 7.0.
External fonts load, but do not display correctly
Default LVGL 6.0 font does not display special characters
Further extend TFT_LVGL_UI to work with other boards/TFTs, especially those without much SPI flash (Chitu/Tronxy X5SA, etc.)
Several screens are missing compared to MKS' old/proprietary TFT firmware

My Configurations

This is a general issue with MKS's LVGL implementation, so it applies to all configs with TFT_LVGL_UI_FSMC/TFT_LVGL_UI_SPI enabled.

The text was updated successfully, but these errors were encountered:

makerbase-mks · 2020-07-01T08:27:09Z

@rhapsodyv @thisiskeithb
The bugfix-2.0.x version submitted by rhapsodyv has been tested and found that Chinese and Russian languages can be displayed. Due to the problem of address offset, the display is not complete enough. I need to change it.

The following picture shows the problem that occurred after I updated the latest font. I need to modify the font offset in the code to solve this problem.
https://github.com/makerbase-mks/Mks-Robin-Nano-Marlin2.0-Firmware/tree/master/Firmware/mks_font

The interface shown in the following picture is the normal interface displayed after I updated the old version of the font
https://github.com/makerbase-mks/Mks-Robin-Nano-Marlin2.0-Firmware/tree/v2.0.5.3/Firmware/mks_font

thisiskeithb · 2020-07-01T08:38:29Z

The bugfix-2.0.x version submitted by rhapsodyv has been tested and found that Chinese and Russian languages can be displayed. Due to the problem of address offset, the display is not complete enough. I need to change it.

Sounds like a simple fix. There's still an issue with some special characters not being displayed.

In your photos above, "franais" should be "français":

Marlin/Marlin/src/lcd/extui/lib/mks_ui/tft_multi_language.h

Line 535 in e5bc9d3

#define LANGUAGE_FR "français"

and "espaol" should be "español":

Marlin/Marlin/src/lcd/extui/lib/mks_ui/tft_multi_language.h

Line 541 in e5bc9d3

#define LANGUAGE_SP "español"

@rhapsodyv was able to update to LVGL 7.0 without modifying your fork. but I don't think they've tested special characters yet.

ftoz1 · 2020-07-01T09:10:23Z

Seem to me wrong way add lvlg issues to many files as y present. There should be one lvlg starter file instead of ultralcd.cpp which inicialize gui.

thisiskeithb · 2020-07-01T09:34:49Z

Seem to me wrong way add lvlg issues to many files as y present. There should be one lvlg starter file instead of ultralcd.cpp which inicialize gui.

Can you clarify what this means?

This is a beta feature that is a work in progress. Expect frequent updates as this feature is updated and expanded to more hardware.

ftoz1 · 2020-07-01T10:12:37Z

Its not depend if beta of what stage it is, but all lcd issues should be only in /lcd dir. And marlin.cpp should call init gui and update gui. There cant be gui issues across all marlin files. It sucks me as hell on marlin. The reason is simple if y want to use another ui/gui, y get big stop by many ui issues in gcodes and in hundred files. I am now refresh work on it and seems to share some experimental working version till week. But i am always trouble with basic things on marlin. Dual Z motor not work on latest versions, so always need to solve basic things.

thisiskeithb · 2020-07-01T10:21:43Z

@ftoz1: It sounds like you have a misunderstanding of how Marlin is organized and configured and those are not related to LVGL/this issue.

For best results getting help with configuration and troubleshooting, please use the following resources:

MarlinFW.org Marlin Documentation
RepRap.org Marlin Forum
Tom's 3D Forums
Facebook Group "Marlin Firmware"
Facebook Group "Marlin Firmware for 3D Printers"
Marlin Configuration on YouTube
Marlin Discord server. Join link: https://discord.gg/n5NJ59y

ftoz1 · 2020-07-01T10:53:13Z

good luck.
https://www.youtube.com/watch?v=3coW24_y9d8&feature=youtu.be

rhapsodyv · 2020-07-01T13:45:03Z

@rhapsodyv @thisiskeithb
The bugfix-2.0.x version submitted by rhapsodyv has been tested and found that Chinese and Russian languages can be displayed. Due to the problem of address offset, the display is not complete enough. I need to change it.

The following picture shows the problem that occurred after I updated the latest font. I need to modify the font offset in the code to solve this problem.

@makerbase-mks

Did you fixed the offset? What’s to commit to my branch?

rhapsodyv · 2020-07-01T13:47:16Z

good luck.
https://www.youtube.com/watch?v=3coW24_y9d8&feature=youtu.be

All the lvgl code is isolated in lcd folder. There’re only two from Marlin core: init and update loop.

ftoz1 · 2020-07-01T14:18:34Z

I am saying that, because original marlin cause many troubles by that. There are a lot of ui issues everywhere and i am stuck on it. If want keep marlin with open mind changeable ui, its good to keep file structure.

GMagician · 2020-07-01T15:58:43Z

@thisiskeithb and Italian is "Italiano" not "Italia" :-)

thisiskeithb · 2020-07-01T17:26:41Z

@thisiskeithb and Italian is "Italiano" not "Italia" :-)

I didn’t write the translations. I’m just pointing out the missing characters.

GMagician · 2020-07-01T17:31:45Z

@thisiskeithb you may think about a new job :-D

thisiskeithb · 2020-07-01T17:33:31Z

@thisiskeithb you may think about a new job :-D

What do you mean by that?

GMagician · 2020-07-01T17:34:46Z

It was a joke, you may think to start to be a translator, no offense

thisiskeithb · 2020-07-01T17:39:14Z

Marlin is accepting pull requests, so feel free to correct translation errors.

makerbase-mks · 2020-07-02T12:22:25Z

@thisiskeithb Thank you for your suggestion，I have submitted my changes.
I merged @rhapsodyv 's code, the test found that it worked very well.
The following content is my submission link
#18500

I haven't updated the graphics library to 7.0 yet, I think I will cooperate with @rhapsodyv to do this job well.
The following are my tests on robin_nano_v1.2 and V2.0 after the merger

ftoz1 · 2020-07-02T12:44:35Z

How fast is approx draw page on nano with that?

rhapsodyv · 2020-09-03T02:03:44Z

I think we can update the progress

thisiskeithb · 2020-10-05T04:15:52Z

@makerbase-mks Is updating to LVGL 7.x still planned? They are up to version 7.6 now.

ellensp · 2020-10-22T03:25:15Z

several parts of the code for MKS_UI code calls "card." without checking sdsupport is actually enabled
egs
mks_ui/draw_print_file.cpp:549:3: error: 'card' was not declared in this scope
mks_ui/printer_operation.cpp:237:5: error: 'card' was not declared in this scope

rhapsodyv · 2020-10-22T03:32:41Z

several parts of the code for MKS_UI code calls "card." without checking sdsupport is actually enabled
egs
mks_ui/draw_print_file.cpp:549:3: error: 'card' was not declared in this scope
mks_ui/printer_operation.cpp:237:5: error: 'card' was not declared in this scope

LVGL ui will not work without SDSUPPORT because it needs to loads the assets.

Maybe we should put a sanity check to remember the user to enable it.

ellensp · 2020-10-22T03:45:25Z

makes sense, but then the blocks of code like "#if ENABLED(SDSUPPORT)" don't....

rhapsodyv · 2020-10-22T04:11:00Z

makes sense, but then the blocks of code like "#if ENABLED(SDSUPPORT)" don't....

Sure... those blocks don't make sense... at least now.

Maybe in the future, when we have a light version of the lvgl, without assets loading

github-actions · 2020-12-25T14:07:12Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

thisiskeithb mentioned this issue Jun 30, 2020

TFT_LITTLE_VGL_UI for everyone #18438

Merged

thisiskeithb changed the title ~~[BUG] TFT_LITTLE_VGL_UI external font loading, special characters no displayed, missing screens~~ [BUG] TFT_LITTLE_VGL_UI external font loading, missing special characters, missing screens Jun 30, 2020

thisiskeithb added the C: LCD & Controllers label Jun 30, 2020

thisiskeithb changed the title ~~[BUG] TFT_LITTLE_VGL_UI external font loading, missing special characters, missing screens~~ [BUG] TFT_LVGL_UI external font loading, missing special characters, missing screens Jul 1, 2020

thisiskeithb changed the title ~~[BUG] TFT_LVGL_UI external font loading, missing special characters, missing screens~~ [FR] WIP:TFT_LVGL_UI external font loading, missing special characters, missing screens Jul 1, 2020

thisiskeithb added the T: Feature Request Features requested by users. label Jul 1, 2020

thisiskeithb changed the title ~~[FR] WIP:TFT_LVGL_UI external font loading, missing special characters, missing screens~~ [FR] WIP: MKS UI/TFT_LVGL_UI Updates & Fixes Oct 5, 2020

thisiskeithb closed this as completed Oct 22, 2020

github-actions bot locked and limited conversation to collaborators Dec 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FR] WIP: MKS UI/TFT_LVGL_UI Updates & Fixes #18476

[FR] WIP: MKS UI/TFT_LVGL_UI Updates & Fixes #18476

thisiskeithb commented Jun 30, 2020 •

edited

Loading

makerbase-mks commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

ftoz1 commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

ftoz1 commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020 •

edited

Loading

ftoz1 commented Jul 1, 2020 •

edited

Loading

rhapsodyv commented Jul 1, 2020 •

edited

Loading

rhapsodyv commented Jul 1, 2020

ftoz1 commented Jul 1, 2020

GMagician commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

GMagician commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

GMagician commented Jul 1, 2020 •

edited

Loading

thisiskeithb commented Jul 1, 2020

makerbase-mks commented Jul 2, 2020 •

edited

Loading

ftoz1 commented Jul 2, 2020

rhapsodyv commented Sep 3, 2020

thisiskeithb commented Oct 5, 2020

ellensp commented Oct 22, 2020

rhapsodyv commented Oct 22, 2020 •

edited

Loading

ellensp commented Oct 22, 2020

rhapsodyv commented Oct 22, 2020

github-actions bot commented Dec 25, 2020

[FR] WIP: MKS UI/TFT_LVGL_UI Updates & Fixes #18476

[FR] WIP: MKS UI/TFT_LVGL_UI Updates & Fixes #18476

Comments

thisiskeithb commented Jun 30, 2020 • edited Loading

Bug Description

To-do

Complete

My Configurations

makerbase-mks commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

ftoz1 commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

ftoz1 commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020 • edited Loading

ftoz1 commented Jul 1, 2020 • edited Loading

rhapsodyv commented Jul 1, 2020 • edited Loading

rhapsodyv commented Jul 1, 2020

ftoz1 commented Jul 1, 2020

GMagician commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

GMagician commented Jul 1, 2020

thisiskeithb commented Jul 1, 2020

GMagician commented Jul 1, 2020 • edited Loading

thisiskeithb commented Jul 1, 2020

makerbase-mks commented Jul 2, 2020 • edited Loading

ftoz1 commented Jul 2, 2020

rhapsodyv commented Sep 3, 2020

thisiskeithb commented Oct 5, 2020

ellensp commented Oct 22, 2020

rhapsodyv commented Oct 22, 2020 • edited Loading

ellensp commented Oct 22, 2020

rhapsodyv commented Oct 22, 2020

github-actions bot commented Dec 25, 2020

thisiskeithb commented Jun 30, 2020 •

edited

Loading

thisiskeithb commented Jul 1, 2020 •

edited

Loading

ftoz1 commented Jul 1, 2020 •

edited

Loading

rhapsodyv commented Jul 1, 2020 •

edited

Loading

GMagician commented Jul 1, 2020 •

edited

Loading

makerbase-mks commented Jul 2, 2020 •

edited

Loading

rhapsodyv commented Oct 22, 2020 •

edited

Loading