Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add white frame to dwin display selection #19366

Closed
jdogmcsteezy opened this issue Sep 12, 2020 · 5 comments
Closed

[FR] Add white frame to dwin display selection #19366

jdogmcsteezy opened this issue Sep 12, 2020 · 5 comments
Labels
T: Feature Request Features requested by users.

Comments

@jdogmcsteezy
Copy link
Contributor

Description

Add white frame to icon selection for the ender 3 v2 dwin display. This would make the UI more pleasant and easier to use. Currently, the selection is difficult to see if not looking from directly above it. I provided a video below that clearly shows the problem.

Feature Workflow

  1. When printer is turned on the menus Print Icon will have a white box around it indicating it is selected.
  2. The rotary encoder is turned to select Prepare Icon and a white box is displayed around it indicating it is selected.
  3. Print Icon white box is erased indicating it has been deselected. And so on . . .

Additional Information

@CRCinAU
Copy link
Contributor

CRCinAU commented Sep 13, 2020

Nice first PR - thanks for the contribution - saves being 'yet another thing' for me to hunt down :)

@thisiskeithb
Copy link
Member

PR has been merged. Closing.

@jdogmcsteezy
Copy link
Contributor Author

@CRCinAU Thanks! Really happy to be able to contribute! If I have any questions about the DWIN code for further improvements who should I ping?

@CRCinAU
Copy link
Contributor

CRCinAU commented Sep 14, 2020

@jdogmcsteezy - Best place is probably the discord channel: https://discord.gg/AeRTDxh

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

3 participants