Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SanityCheck warning errors running build for LPC1768 and LPC1769 #22265

Closed
xeddog opened this issue Jun 29, 2021 · 4 comments
Closed

SanityCheck warning errors running build for LPC1768 and LPC1769 #22265

xeddog opened this issue Jun 29, 2021 · 4 comments

Comments

@xeddog
Copy link

xeddog commented Jun 29, 2021

Did you test the latest bugfix-2.0.x code?

No, but I will test it now!

Bug Description

I get a large amount of warning messages when running build for LPC1768 and LPC1769 processors. This is related to #22259. Line 3595 of SanityCheck.h looks like:

#error "SLIM_LCD_MENUS disables "Advanced Settings > Probe Offsets > PROBE_OFFSET_WIZARD."

It looks like it is missing the quote marks after SLIM_LCD_MENUS. I added the closing quotes and reran the builds and they ran clean with no warning.

Bug Timeline

new today after running pull

Expected behavior

Build without the warnings

Actual behavior

Many warning messages during build

Steps to Reproduce

Using the latest VSCode, I Ran Clean followed by Build.

Version of Marlin Firmware

2.0.9.1

Printer model

Monoprice Mini and Creality CR-10S

Electronics

Mini running the SKR V1.3 and the Creality running the SKR V1.4

Add-ons

No response

Your Slicer

Cura

Host Software

OctoPrint

Additional information & file uploads

No response

@slowbro
Copy link
Member

slowbro commented Jun 29, 2021

Looks like this was just fixed a few minutes ago.

cd01421

@xeddog
Copy link
Author

xeddog commented Jun 29, 2021

I see that. Not the way I did it so I need to go back and fix my fix. :-)

@thisiskeithb
Copy link
Member

Patched in cd01421.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants