Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't compile for Ender 3 V2 with AUTO_BED_LEVELING_(BI)LINEAR uncommented. #22588

Closed
lefterisgar opened this issue Aug 17, 2021 · 9 comments

Comments

@lefterisgar
Copy link
Contributor

lefterisgar commented Aug 17, 2021

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

PlatformIO refuses to compile with the following error(s):

Compiling .pio\build\STM32F103RET6_creality\src\src\lcd\e3v2\creality\dwin.cpp.o
Marlin\src\lcd\e3v2\creality\dwin.cpp: In function 'void Item_Adv_ProbeOffsets(uint8_t)':
Marlin\src\lcd\e3v2\creality\dwin.cpp:2429:33: error: too many arguments to function 'void say_probe_offs_en(uint8_t)'
 2429 |         say_probe_offs_en(0, row);
      |                                 ^
Marlin\src\lcd\e3v2\creality\dwin.cpp:567:6: note: declared here
  567 | void say_probe_offs_en(const uint8_t row) {
      |      ^~~~~~~~~~~~~~~~~
*** [.pio\build\STM32F103RET6_creality\src\src\lcd\e3v2\creality\dwin.cpp.o] Error 1

Bug Timeline

It started with commit 09af42e (17-08-2021).

Expected behavior

I expected to be able to successfully compile Marlin firmware with the options below (steps to reproduce) enabled.

Actual behavior

Compiling .pio\build\STM32F103RET6_creality\src\src\lcd\e3v2\creality\dwin.cpp.o fails.

Steps to Reproduce

  1. Clone Marlin.
  2. Import Ender 3 V2 configurations.
  3. Uncomment #define BLTOUCH.
  4. Uncomment #define Z_SAFE_HOMING.
  5. Uncomment any of these:
  • //#define AUTO_BED_LEVELING_3POINT
  • //#define AUTO_BED_LEVELING_LINEAR
  • //#define AUTO_BED_LEVELING_BILINEAR
  1. Compile Marlin.

Version of Marlin Firmware

Latest bugfix 2.0.x

Printer model

Creality Ender 3 V2

Electronics

  • Creality 4.2.2 mainboard (STM32F103RET6_CREALITY)
  • DWIN LCD display
  • BLTouch
  • Filament run-out sensor

Add-ons

BLTouch, Filament run-out sensor

Bed Leveling

ABL Bilinear mesh

Additional information & file uploads

Configs.zip
image

I went to line 2429 of dwin.cpp and changed it from
say_probe_offs_en(0, row); to say_probe_offs_en(row); and it did successfully compile.

@lefterisgar lefterisgar changed the title [BUG] Can't compile for Ender 3 V2. [BUG] Can't compile for Ender 3 V2 with AUTO_BED_LEVELING_XXX uncommented. Aug 17, 2021
@lefterisgar lefterisgar changed the title [BUG] Can't compile for Ender 3 V2 with AUTO_BED_LEVELING_XXX uncommented. [BUG] Can't compile for Ender 3 V2 with AUTO_BED_LEVELING_(BI)LINEAR uncommented. Aug 17, 2021
@lefterisgar lefterisgar changed the title [BUG] Can't compile for Ender 3 V2 with AUTO_BED_LEVELING_(BI)LINEAR uncommented. [BUG] Can't compile for Ender 3 V2 with #define AUTO_BED_LEVELING_(BI)LINEAR uncommented. Aug 17, 2021
@lefterisgar lefterisgar changed the title [BUG] Can't compile for Ender 3 V2 with #define AUTO_BED_LEVELING_(BI)LINEAR uncommented. [BUG] Can't compile for Ender 3 V2 with AUTO_BED_LEVELING_(BI)LINEAR uncommented. Aug 17, 2021
@ellensp
Copy link
Contributor

ellensp commented Aug 18, 2021

This PR broke it #22586

@ellensp
Copy link
Contributor

ellensp commented Aug 18, 2021

Issues resulting from Clean up CrealityUI and MarlinUI #22586
No change with " Followup to CrealityUI cleanup" 11e8cd9

@lefterisgar
Copy link
Contributor Author

lefterisgar commented Aug 18, 2021

Well, thank you soo much!! Really appreciate your help!

@lefterisgar
Copy link
Contributor Author

lefterisgar commented Aug 18, 2021

Closure was accidental.

@rankinstudio
Copy link

I just ran into this bug as well, any fix?

@lefterisgar
Copy link
Contributor Author

No and I guess till the E3V2 cleanup ends we will be having a lot of issues like this...

@thinkyhead
Copy link
Member

We'll see about "a lot." Meanwhile I can quickly patch this as soon as I get back from the grocery store.

@lefterisgar
Copy link
Contributor Author

lefterisgar commented Aug 19, 2021

Nice! Accidents always happen and it's not your fault. Having to maintain such a big codebase is rocket science to me and a lot of other people... 😁 Really appreciate your job and looking forward to the end of the cleanup!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants