Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "always_inline function might not be inlinable": warning / [FR] STM32F103RC_creality_maple added to Creality_V4+ #26336

Closed
1 task done
classicrocker883 opened this issue Oct 12, 2023 · 5 comments

Comments

@classicrocker883
Copy link
Contributor

classicrocker883 commented Oct 12, 2023

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

since the recent commit 🩹 Remove extraneous 'inline'
See #26085

I receive this warning using the stmf1-maple.ini
env: STM32F103RE_creality_maple

Marlin\src\HAL\STM32F1\MarlinSerial.cpp:31:29: warning: always_inline function might not be inlinable [-Wattributes]
 static __always_inline void my_usart_irq(ring_buffer *rb, ring_buffer *wb, usart_reg_map *regs, MSerialT &serial) {

file in question...
src/HAL/STMF1/MarlinSerial.cpp

side note (Feature Request):
env: STM32F103RC_creality_maple should be added to the CREALITY_V4...422/427 in src/pins.h file

Bug Timeline

new, since 🩹 Remove extraneous 'inline'

Expected behavior

I do not expect a warning to appear.

Actual behavior

warning when focing "inline" removed

Steps to Reproduce

  1. Use a standard Ender-3 V2 configuration
  2. Set to STM32F103RE_creality_maple as default_envs in platformio.ini
  3. Compile

Ender3V2Configs.zip

Version of Marlin Firmware

bugfix-2.1.x

Printer model

Voxelab Aquila

Electronics

No response

Add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@classicrocker883
Copy link
Contributor Author

classicrocker883 commented Oct 12, 2023

I did a quick test using STM32F103RC_btt_maple (which according to #26085 received a fatal error) and such error did not occur for me.

having said, it uses toolchain-gccarmnoneeabi @ 1.70201.0 (7.2.1) by default. why it would be set to toolchain-gccarmnoneeabi @ 1.90301.200702 (9.3.1) I do not know, I didn't mess with changing that sort of thing. So I think we can revert that commit and put back inline.

@ellensp
Copy link
Contributor

ellensp commented Oct 12, 2023

maple is obsolete

going back to it is so wrong on so many levels.

It is not the correct way to support GD32

Copy link

Greetings from the Marlin AutoBot!
This issue has had no activity for the last 90 days.
Do you still see this issue with the latest bugfix-2.1.x code?
Please add a reply within 14 days or this issue will be automatically closed.
To keep a confirmed issue open we can also add a "Bug: Confirmed" tag.

Disclaimer: This is an open community project with lots of activity and limited
resources. The main project contributors will do a bug sweep ahead of the next
release, but any skilled member of the community may jump in at any time to fix
this issue. That can take a while depending on our busy lives so please be patient,
and take advantage of other resources such as the MarlinFirmware Discord to help
solve the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
@classicrocker883
Copy link
Contributor Author

maple is obsolete

going back to it is so wrong on so many levels.

It is not the correct way to support GD32

just wanted to mention that I heard it might be possible to update the bootloader to accept STM32F103RC_creality without the maple. but that requires something like St-link.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants