Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ender 3 v2 compile failed with ProUI #26476

Closed
1 task done
dmitrygribenchuk opened this issue Nov 28, 2023 · 3 comments
Closed
1 task done

Ender 3 v2 compile failed with ProUI #26476

dmitrygribenchuk opened this issue Nov 28, 2023 · 3 comments
Labels
Bug: Confirmed ! Fix Included A fix is included in the description

Comments

@dmitrygribenchuk
Copy link
Contributor

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Hello. When I try to build firmware for Ender 3 v2 (STM32F103RE_creality) with ProUI enabled (#define DWIN_LCD_PROUI) I have an error:

Compiling .pio/build/STM32F103RE_creality/src/src/sd/SdBaseFile.cpp.o
Marlin/src/lcd/e3v2/proui/dwin.cpp: In function 'void dwinPrintAborted()':
Marlin/src/lcd/e3v2/proui/dwin.cpp:1725:3: error: 'hostui' was not declared in this scope
1725 | hostui.notify("Print Aborted");
| ^~~~~~
Compiling .pio/build/STM32F103RE_creality/src/src/sd/SdFatUtil.cpp.o
*** [.pio/build/STM32F103RE_creality/src/src/lcd/e3v2/proui/dwin.cpp.o] Error 1

Bug Timeline

Last success build was about 2 weeks ago

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

bugfix-2.1.x

Printer model

Ender 3 v2

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

Cura

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration.h.gz
Configuration_adv.h.gz

@ellensp
Copy link
Contributor

ellensp commented Nov 28, 2023

#26308 didn't check if HOST_PROMPT_SUPPORT is enabled or not, it just assumed that it was

It also added the string "Print Aborted" when marlin already has MSG_PRINT_ABORTED which supports multiple languages

The fix is really simple

diff --git a/Marlin/src/lcd/e3v2/proui/dwin.cpp b/Marlin/src/lcd/e3v2/proui/dwin.cpp
index 366ecffbd9..8d4aa9106b 100644
--- a/Marlin/src/lcd/e3v2/proui/dwin.cpp
+++ b/Marlin/src/lcd/e3v2/proui/dwin.cpp
@@ -1722,7 +1722,7 @@ void dwinPrintAborted() {
       );
     }
   #endif
-  hostui.notify("Print Aborted");
+  TERN_(HOST_PROMPT_SUPPORT, hostui.notify(GET_TEXT_F(MSG_PRINT_ABORTED)));
   dwinPrintFinished();
 }

@ellensp ellensp added Bug: Confirmed ! Fix Included A fix is included in the description labels Nov 28, 2023
@ellensp
Copy link
Contributor

ellensp commented Nov 28, 2023

I have added a PR to fix this

@ellensp ellensp closed this as completed Nov 28, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug: Confirmed ! Fix Included A fix is included in the description
Projects
None yet
Development

No branches or pull requests

2 participants