Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu freeze while Z is moving manual #3836

Closed
Massa0815 opened this issue May 25, 2016 · 6 comments
Closed

Menu freeze while Z is moving manual #3836

Massa0815 opened this issue May 25, 2016 · 6 comments
Labels
Bug: Confirmed ! Needs: Testing Testing is needed for this change
Milestone

Comments

@Massa0815
Copy link

Massa0815 commented May 25, 2016

Hi
I set up a newSmartrap wirth Marlin 1.1.0 RC6.

When i move Z axis manualy per "Prepare" menu it is not possible to change the position with the rotary knob while z is moving. I have to wait until Z stops to increase or decrease the target position.

I have a version 1.0.6 on my Prusa i3. With this Version it works fine.

I Use Ramps 1.4 with 2004 Char LCD

@thinkyhead
Copy link
Member

@Massa0815 Sorry about this behavior. The change was made to prevent the controller from having the wrong value on-screen but dropping the last move. There's a patch in the queue that needs more testing, but it will fix this behavior, add a short delay to the movement control, and prevent the last move from being dropped. The PR is #3110, and the full branch can be downloaded at https://github.com/thinkyhead/Marlin/tree/rc_manual_moves

@jbrazio jbrazio added this to the 1.1.0 milestone May 27, 2016
@jbrazio jbrazio added the Needs: Testing Testing is needed for this change label May 27, 2016
@thinkyhead
Copy link
Member

I've merged #3110 so that manual moves are no longer blocked, and so that there is a 1/2 second delay before a move starts. The upshot of this is that when trying to do very precise short moves, you must wait 1/2 second after each "tick" of the controller wheel. So perhaps this delay could be made shorter when doing very short moves such X or Y by <= 1mm.

Give the latest code a try and see if it behaves in a way that feels right.

@Massa0815
Copy link
Author

I testet it. It works better, but the delay is a little bit to high for my taste. Its a bit to annoying whne the movement comes so late.

@thinkyhead
Copy link
Member

@Massa0815 Try some lower delay values and see if there's one that feels better. Currently it's a 1/2 second, so maybe 1/4 second is better. Just alter the value here:

inline void manual_move_to_current(AxisEnum axis) {
  manual_move_start_time = millis() + 500UL; // 1/2 second delay
  manual_move_axis = (int8_t)axis;
}

@jbrazio
Copy link
Contributor

jbrazio commented Jul 11, 2016

Thank you for your interest making Marlin better and reporting this issue but this topic has been open for a long period of time without any further development. Marlin has been under heavy development for the past couple of months and moving to it's last mile to finish the RC cycle and release Marlin v1.1.0. We suggest you to try out the latest RCBugfix branch and reopening this issue if required.

@jbrazio jbrazio closed this as completed Jul 11, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 16, 2016
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug: Confirmed ! Needs: Testing Testing is needed for this change
Projects
None yet
Development

No branches or pull requests

3 participants