Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe Home travel speed slow #4079

Closed
SimonGolding opened this issue Jun 18, 2016 · 2 comments
Closed

Safe Home travel speed slow #4079

SimonGolding opened this issue Jun 18, 2016 · 2 comments

Comments

@SimonGolding
Copy link

SimonGolding commented Jun 18, 2016

I have just used a new copy of marlin 1.1.0 RC6 running on a Prusa i3 and found an issue with safe homing and auto levelling

Basically it would home X and Y at the correct speed then move to the middle of the bed at the speed for the Z axis which was really slow. This also affect G29 auto level (Im using an inductive probe) making it very slow.

I have made two changes to the code that have corrected the issue Marlin_main.cpp

Line 1646: feedrate = xy_travel_speed;
changed to feedrate = XY_TRAVEL_SPEED;

Not sure if this has any affect infact it looks like the var xy_travel_speed is no longer used once replaced with this constant.

I also modified line 1537 of marlin_main.cpp by adding

float oldFeedRate = feedrate;

at the beginning of the function then restored the feedrate at the end of the function.

Thanks
Simon

@thinkyhead
Copy link
Member

The saving and restoring of the feed rate makes sense, so I've added that to a few functions in PR #4080.

As I look at the code, I see that xy_travel_speed is initialized to XY_TRAVEL_SPEED but it is meant to be overridden by G29 Snn (for Automatic Bed Leveling). If you leave off the S parameter, it is set to XY_TRAVEL_SPEED. So it should be fine to leave feedrate = xy_travel_speed in place.

@thinkyhead thinkyhead added this to the 1.1.0 milestone Jun 20, 2016
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants