You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Great work on the project. I came across some things (will probability make a PR).
The Toast isn't mounted on the Root and so e.g. this.$root or this.$store doesn't point to the original Vue instance in component toasts, and the eventbus/props/listeners stuff isn't ideal - I did try to dive into it but couldn't manipulate the parent option on Vue.extendhttps://github.com/Maronato/vue-toastification/blob/master/src/ts/interface.ts#L22 - solution could be just allowing that to be passed to createToastInterface ?
It's quite inconvenient to disable transitions for each individual Toast - could allow it to be manipulated per toast (even via the component trigger)?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi Everyone,
Great work on the project. I came across some things (will probability make a PR).
The Toast isn't mounted on the Root and so e.g.
this.$root
orthis.$store
doesn't point to the original Vue instance in component toasts, and the eventbus/props/listeners stuff isn't ideal - I did try to dive into it but couldn't manipulate theparent
option onVue.extend
https://github.com/Maronato/vue-toastification/blob/master/src/ts/interface.ts#L22 - solution could be just allowing that to be passed to createToastInterface ?It's quite inconvenient to disable transitions for each individual Toast - could allow it to be manipulated per toast (even via the component trigger)?
What does everyone think?
Beta Was this translation helpful? Give feedback.
All reactions