-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only first job context is taken into consideration. #2230
Comments
The other solution proposed by @wslulciuc is to use facets directly and deprecate |
I agree, those features can be fetched from facets directly. If there's no other uses for |
(Sorry for the late reply, @JDarDagran). The |
Problem
Job context is a structure that serves as code location / SQL container to show them in Marquez UI. Job context upsert takes only checksum on context's body on conflict. This means that when e.g. at the start and the end of job the context is different there would be 2 different entries in
job_context
table for this job. That still might be ok, however this has its result in exposing in API only first captured context which means if you don't send SqlJobFacet in the START event you won't see it even if you send it in the COMPLETE event.Solutions
I foresee couple of ways to solve this problem:
job_context_uuid
when upserting intoruns
table. This will result in getting only most recent context exposed which might be acceptable but probably not.job_contexts
table: replacecontext
column with 3 following:code_location_type
,code_location_url
,sql
which would be filled on upsert. Some concatenation would still be needed probably.The text was updated successfully, but these errors were encountered: