From bf48e10a57a40fc88e5f266229b0f3e1af73b05e Mon Sep 17 00:00:00 2001 From: sharpd Date: Thu, 18 Apr 2024 09:24:11 +1200 Subject: [PATCH 1/2] fix show tags fresh Signed-off-by: sharpd --- web/src/components/datasets/DatasetDetailPage.tsx | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/web/src/components/datasets/DatasetDetailPage.tsx b/web/src/components/datasets/DatasetDetailPage.tsx index a239d0c6a0..8e3ee63994 100644 --- a/web/src/components/datasets/DatasetDetailPage.tsx +++ b/web/src/components/datasets/DatasetDetailPage.tsx @@ -105,13 +105,7 @@ const DatasetDetailPage: FunctionComponent = (props) => { useEffect(() => { fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name) - }, [lineageDataset.name]) - - useEffect(() => { - if (showTags) { - fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name) - } - }, [showTags]) + }, [lineageDataset.name, showTags]) // if the dataset is deleted then redirect to datasets end point useEffect(() => { From 78e23d3270d85b6c341b9191d517680baaf590b1 Mon Sep 17 00:00:00 2001 From: sharpd Date: Thu, 18 Apr 2024 12:34:19 +1200 Subject: [PATCH 2/2] disable show tags on version load Signed-off-by: sharpd --- web/src/components/datasets/DatasetDetailPage.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/web/src/components/datasets/DatasetDetailPage.tsx b/web/src/components/datasets/DatasetDetailPage.tsx index 8e3ee63994..cb387b7938 100644 --- a/web/src/components/datasets/DatasetDetailPage.tsx +++ b/web/src/components/datasets/DatasetDetailPage.tsx @@ -213,6 +213,7 @@ const DatasetDetailPage: FunctionComponent = (props) => { checked={showTags} onChange={() => setShowTags(!showTags)} inputProps={{ 'aria-label': 'toggle show tags' }} + disabled={versionsLoading} /> } label={i18next.t('datasets.show_field_tags')}