Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please flush out v3 Changelog #127

Closed
kevinburke opened this issue Sep 23, 2019 · 3 comments
Closed

Please flush out v3 Changelog #127

kevinburke opened this issue Sep 23, 2019 · 3 comments

Comments

@kevinburke
Copy link

Hi,
I'm trying to update golang/dep to use the latest version of this library but I've run into a few problems.

  • Previously you could cast the result of semver.NewConstraint to a semver.Version. Now you can't. The CHANGELOG gives no guidance on how to update this.
  • semver.NewConstraintIC seems to have disappeared and there's no guidance in the CHANGELOG on how to update it.

Confusingly, when I generate a diff of the version we're on vs. master, NewConstraintIC isn't even in it as being removed. So I'm not even sure where to get started. 24642bd...fe7c210

@kevinburke
Copy link
Author

If you want to reproduce you can check out the build here. https://travis-ci.org/golang/dep/builds/588252088

@mattfarina
Copy link
Member

@kevinburke dep uses an unreleased version of sermver with a different Go API from either the 1.x branch of the 3.x branch. From the README.md...

There are three major versions of the semver package.

  • 3.x.x is the new stable and active version. This version is focused on constraint compatibility for range handling in other tools from other languages. It has a similar API to the v1 releases. The development of this version is on the master branch. The documentation for this version is below.
  • 2.x was developed primarily for dep. There are no tagged releases and the development was performed by @sdboyer. There are API breaking changes from v1. This version lives on the 2.x branch.
  • 1.x.x is the most widely used version with numerous tagged releases. This is the previous stable and is still maintained for bug fixes. The development, to fix bugs, occurs on the release-1 branch. You can read the documentation here.

The 2.x branch was never released and I'm not sure anyone other than dep is using it.

If I understand it right, dep is going to be archived in the not to distant future (unless something changed since last I checked). I would suggest keeping dep on 2.x.

@mattfarina
Copy link
Member

For reference on my archiving comment see golang/go#29639 (comment) where it says

Once modules is moved out of experimental (we are targeting Go 1.13), we will likely archive the dep repo shortly after to avoid confusion on which dependency management solution the Go project officially supports. We will do our best to communicate when exactly the archive will happen to avoid surprise, but it should be planned for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants