Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stealth mode feature. #199

Closed
tegefaulkes opened this issue Jul 5, 2021 · 5 comments
Closed

Stealth mode feature. #199

tegefaulkes opened this issue Jul 5, 2021 · 5 comments
Assignees
Labels
design Requires design enhancement New feature or request r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@tegefaulkes
Copy link
Contributor

There may be a need for a stealth mode feature for Polykey But it is not currently MVP.
I'm not sure that stealth mode would do. It might just tell the current node to show as offline. @CMCDragonkai could you add any more details?

@tegefaulkes tegefaulkes added the design Requires design label Jul 5, 2021
@CMCDragonkai
Copy link
Member

Check the polykey-design issues, is stealth mode mentioned there?

@tegefaulkes
Copy link
Contributor Author

I can't find anything in the design issues. there is src-old/nodes/NodeManager.ts:179 in the old code.

@CMCDragonkai CMCDragonkai added the enhancement New feature or request label Jul 5, 2021
@joshuakarp
Copy link
Contributor

There's a comment about it here: https://gitlab.com/MatrixAI/Engineering/Polykey/polykey-design/-/issues/31#note_495622490. This is the only further information I could find.

@CMCDragonkai
Copy link
Member

I believe the stealth mode was to prevent it from being discovered. Right now the only kind of node discovery we have is through Kademlia. So stealth would just mean the node does not respond or participate in the Kademlia process.

Additionally due to MatrixAI/js-mdns#1, stealth mode would also mean the node does not respond to LAN multicast discovery.

I'm not sure if it should also ignore scan/ping/keepalive. I reckon direct connections should still occur. But this requires a UI/UX review.

@CMCDragonkai
Copy link
Member

Going to cancel this, as this doesn't really fit within the rest of the PK design now. In fact with authenticated networks and network segregation @amydevs it stealth mode would simply mean not connecting to any of the named networks - and therefore the networking layer would just reject connections.

@CMCDragonkai CMCDragonkai closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Requires design enhancement New feature or request r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Development

No branches or pull requests

3 participants