Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions to claims and better validation for processing claims #737

Open
tegefaulkes opened this issue Jun 11, 2024 · 3 comments
Open
Labels
development Standard development r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy

Comments

@tegefaulkes
Copy link
Contributor

Specification

Given recent changes to identity claims, we saw a first hand example of failing to process a claim. In this case the claim was missing a field that we were expecting leading to a failure to process the claims.

So we need to make the following changes to handle this.

  1. Claims need to contain a version field that gets incremented each time the claim schema changes.
  2. We need better error logging for why the claim failed to be processed.

The version number is a simple addition. However when processing a claim we need to do more validation rather than just trusting that it is correct.

Additional context

Tasks

  1. Claims need to contain a version field that gets incremented each time the claim schema changes.
  2. We need better error logging for why the claim failed to be processed.
@tegefaulkes tegefaulkes added the development Standard development label Jun 11, 2024
Copy link

linear bot commented Jun 11, 2024

@tegefaulkes
Copy link
Contributor Author

Any old claims on an identity will break the processing of that identity. Updating the parsing of claims will fix this. Currently we take it as read that the format will be valid if it was a valid claim. But we can have missing fields that we need to verify and handle gracefully.

If we fail to parse a claim on an identity, we need to just skip it with a warning and move on rather than fail to process all the claims.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jun 14, 2024 via email

@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy
Development

No branches or pull requests

2 participants