Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy WebSocketConnection creation to PolykeyClient #772

Closed
wants to merge 1 commit into from

Conversation

amydevs
Copy link
Member

@amydevs amydevs commented Jul 12, 2024

Description

Adds lazy WebSocketConnection creation to PolykeyClient

Issues Fixed

Tasks

  • 1. Add lazy parameter to PolykeyClient

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes
Copy link
Contributor

Looks fine, two things stand out though.

  1. Before it was expected that parameters like ports and addresses would be define while the client is running. This isn't true anymore so it may brake some things making that assumptions. Usually testing if that?
  2. You don't have any tests for the new behaviour. You'll need a few to demostrate the lazy feature along with making sure it works as expected and for catching future regressions.

@amydevs
Copy link
Member Author

amydevs commented Sep 9, 2024

Need to be redone in the future, more considerations must be made as the API will actually change if the PolykeyClient is lazy. We should probably just make 2 separate classes instead for lazy + non-lazy respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Lazy Creation of WebSocketClient within PolykeyClient
2 participants