Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined behaviour error message coming from background tasks #797

Open
tegefaulkes opened this issue Aug 27, 2024 · 1 comment
Open
Labels
development Standard development

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Aug 27, 2024

Specification

When starting an existing agent that hasn't run for a little while we get the following warning logger message.

image

We'll need to find the cause for this and fix it. There aren't many tasks that persist between restarts so it should be simple to narrow down. But in that vein we need to make the following changes to make these problems more clear.

  1. The message should mention which task handler failed.
  2. Any usage of utils.never() should include a descriptive message of what shouldn't be happening. so we need to update all usage of never in a task handler.

Additional context

Tasks

  1. Update the warning log for a failed task handler to include more information about what task was running.
  2. Update the utils.never() usages in task handlers to include proper failure descriptions.
  3. Find and determine the failure occurring here and fix it.
@tegefaulkes tegefaulkes added the development Standard development label Aug 27, 2024
Copy link

linear bot commented Aug 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

1 participant