Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of multiformats is ESM, and this requires ESM migration #19

Open
tegefaulkes opened this issue Sep 12, 2023 · 2 comments
Open
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity

Comments

@tegefaulkes
Copy link
Contributor

Specification

The multiformats dependency has an internal type error. Right now it's being ignored since we added "skipLibCheck": true to the tsconfig.

We need to update the version to where it has been fixed by multiformats but any version above 10.0.0 fails to resolve the imports.

We need to dig into this further, however, it's low priority since it's a type error inside of the library and a warning at that.

Additional context

Tasks

  1. Update the version of multiformats to a version without the type error.
  2. Resolve any issues with importing multiformats.
@tegefaulkes tegefaulkes added the development Standard development label Sep 12, 2023
@CMCDragonkai
Copy link
Member

CMCDragonkai commented Sep 12, 2023

The new js-multiformats is in fact ESM native. I'm not sure if they even produce CJS modules anymore.

This is part of our overall ESM migration problem: MatrixAI/TypeScript-Demo-Lib#32

I'm adding this issue to the epic in TypeScript-Demo-Lib.

@CMCDragonkai CMCDragonkai added the r&d:polykey:supporting activity Supporting core activity label Aug 13, 2024
@CMCDragonkai CMCDragonkai changed the title multiformats type error New version of multiformats is ESM, and this requires ESM migration Aug 23, 2024
@CMCDragonkai
Copy link
Member

This is an example of where ESM can use CJS, but CJS cannot use ESM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity
Development

No branches or pull requests

2 participants