Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New feature] Reddit stories #22

Closed
MatteoFasulo opened this issue Dec 31, 2023 · 8 comments
Closed

[New feature] Reddit stories #22

MatteoFasulo opened this issue Dec 31, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@MatteoFasulo
Copy link
Owner

I have an idea that I have seen in several places. In my case, I am creating Reddit stories, seen that they are being quite successful in those moments. And one feature that I see that everyone has is that, at the beginning of the video, a PNG appears as if it were a Reddit capture. Do you think you could make the script take the PNG fill it with text that has been put in the JSON, put it at the beginning of the video and hide the subtitles at the beginning

I also think it would be good if for example in the middle of the video you could add a subscribe video to encourage people to subscribe.

Thx

Originally posted by @YotomiY in #13 (reply in thread)

@MatteoFasulo MatteoFasulo self-assigned this Dec 31, 2023
@MatteoFasulo MatteoFasulo added enhancement New feature or request help wanted Extra attention is needed labels Dec 31, 2023
@YotomiY
Copy link
Contributor

YotomiY commented Jan 6, 2024

Hello
Just want to explain clearly:
Like this:
image
This is also a great idea to replace the video.json method: At the webui we can ask "How many videos do you want to make?" so you answer (example: 2), "What Subreddit do you want to use?" (example: AskReddit) and "NFSW?" (example: no). Then using selenium (or the Reddit apps API) to extract the title of a post on the specific subreddit with or without nfsw and the content.
We put the title in a PNG template (like shown before, but blank image Found this one on internet)
Put the PNG at the start of the video and replace the"text" on the .json with the content

Also have to add another query : "Number of words or characters on the subtitles" (example: 1 word, 10 Characters)
I also think it would be good to add (optionally) a pup up animation to the subtitles
Thanks

@MatteoFasulo
Copy link
Owner Author

Hello Just want to explain clearly: Like this: image This is also a great idea to replace the video.json method: At the webui we can ask "How many videos do you want to make?" so you answer (example: 2), "What Subreddit do you want to use?" (example: AskReddit) and "NFSW?" (example: no). Then using selenium (or the Reddit apps API) to extract the title of a post on the specific subreddit with or without nfsw and the content. We put the title in a PNG template (like shown before, but blank image Found this one on internet) Put the PNG at the start of the video and replace the"text" on the .json with the content

Also have to add another query : "Number of words or characters on the subtitles" (example: 1 word, 10 Characters) I also think it would be good to add (optionally) a pup up animation to the subtitles Thanks

Hi there,

Thank you for your prompt response. I think it's a great idea to have a submodule for the Reddit-specific functionality within the repository. This way, it maintains modularity, and users interested in that specific feature can easily access and incorporate it without affecting the core functionality.

Before I start working on it, I wanted to check if you have any additional insights or if you think there's a better way to implement this Reddit functionality without making significant modifications to the entire software. Your input will be valuable as I dive into the development process.

Looking forward to your thoughts, and I'll ensure to keep you updated on the progress.

Best regards,
Matteo

@YotomiY
Copy link
Contributor

YotomiY commented Jan 8, 2024

Hello,
Thank you for your answer, For me this functionality could be optional in the gui, for example a checkbox to activate the "reddit" module. When you click, there will be several suboptions with the questions I mentioned the other day (What Subreddit do you want to use? ...). I don't know if it would be possible to make the functionality optional, but it would be cool to have 2 functionalities:

Video.json content, 
Reddit content, 

If it is not possible to create the functionality optionally, then just create a fork or a new branch

Draft here:
Draft new feature Whisper-TikTok
Thank you

PS: 1 = Output video, and I'm having an error: when I create 2 or more videos it only shows 1 video, why not all of them?

Repository owner deleted a comment from YotomiY Jan 10, 2024
@MatteoFasulo
Copy link
Owner Author

Hello, Thank you for your answer, For me this functionality could be optional in the gui, for example a checkbox to activate the "reddit" module. When you click, there will be several suboptions with the questions I mentioned the other day (What Subreddit do you want to use? ...). I don't know if it would be possible to make the functionality optional, but it would be cool to have 2 functionalities:

Video.json content, 
Reddit content, 

If it is not possible to create the functionality optionally, then just create a fork or a new branch

Draft here: Draft new feature Whisper-TikTok Thank you

PS: 1 = Output video, and I'm having an error: when I create 2 or more videos it only shows 1 video, why not all of them?

Hi,
there is only one video even if you generate more videos since Gradio interface expects a single component as output (which in the multiple case will be the last content generated). I'm not so skilled in working with Gradio so be patient while I try to figure out how to do that

Thx

@YotomiY
Copy link
Contributor

YotomiY commented Jan 10, 2024

Ok thanks, and for the reddit fonction?

@MatteoFasulo
Copy link
Owner Author

Ok thanks, and for the reddit fonction?

I'm working on it :)

@MatteoFasulo
Copy link
Owner Author

MatteoFasulo commented Jan 11, 2024

I will also drop Gradio as a WebUI since I am not so confident in working on it. I'll try something with streamlit these days (there is already a version right now).

It should be already visible here: https://convert.streamlit.app/

If you can, test the new dashboard and feel free to make suggestions about it 👍🏼

The reddit stuff will be on the page reddit visible in the sidebar. Still working on it but was not so confident with Gradio env.

@YotomiY
Copy link
Contributor

YotomiY commented Jan 15, 2024

Hello,
How's it going? I am contacting you to tell you if you could inform me about how the new Reddit feature is going. You can also tell me if you need help.
Thanks!

Repository owner locked and limited conversation to collaborators Jan 16, 2024
@MatteoFasulo MatteoFasulo converted this issue into discussion #26 Jan 16, 2024
@MatteoFasulo MatteoFasulo added this to the Reddit milestone Feb 1, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants