Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue size performance issue #15

Closed
matthiasbayer opened this issue Mar 15, 2019 · 1 comment
Closed

Queue size performance issue #15

matthiasbayer opened this issue Mar 15, 2019 · 1 comment
Assignees
Labels
bug domain: performance Issues related to slow performance or high memory usage
Milestone

Comments

@matthiasbayer
Copy link

Hi,

thanks for maintaining this repo, great work!

Are you aware of the performance issues mentioned here:

I created a CodePen using the code from the bug report:

I'd like to use this polyfill in production, but the performance drop, even if unlikely to happen, is a very bad experience for the user.

Do you think it's possible to include a fix (e.g. something like stardazed/sd-streams@1128f0d) into this repository? Or is this not possible because it would be non-standard?

Looking forward to hear you opinion on this.

@MattiasBuelens
Copy link
Owner

MattiasBuelens commented Mar 15, 2019

Ouch, that's quite the performance hit. Thanks for reporting!

I'll look into implementing a fix similar to the one for sd-streams. I'm okay with diverting from the reference implementation, as long as we keep passing all web platform tests. 🙂

@MattiasBuelens MattiasBuelens added this to the v2.0.1 milestone Mar 15, 2019
@MattiasBuelens MattiasBuelens added bug domain: performance Issues related to slow performance or high memory usage labels Mar 15, 2019
@MattiasBuelens MattiasBuelens self-assigned this Mar 16, 2019
MattiasBuelens added a commit that referenced this issue Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug domain: performance Issues related to slow performance or high memory usage
Projects
None yet
Development

No branches or pull requests

2 participants