Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ROS Message Dependencies #2

Open
ekampourakis opened this issue Apr 17, 2020 · 2 comments
Open

Custom ROS Message Dependencies #2

ekampourakis opened this issue Apr 17, 2020 · 2 comments

Comments

@ekampourakis
Copy link

Inside the MaRRTPathPlanNode.py there are 4 non standard ROS messages imported:

  • Map
  • CarSensors
  • WaypointsArray
  • Waypoint

My understanding is that those messages are custom made for the E-gnition vehicle and are not copied to this repository. They seem to be included in the package.xml and the in the package's makefile but they can't be found.

I was able to bypass those dependencies by recreating the messages out of their used attributes in the functions of the script, but it would be awesome if you included a copy of the *.msg files.

@MaxMagazin
Copy link
Owner

Hi @ekampourakis ,
I did not publish these messages on purpose, cause they were not part of my own code and I didn't have permission for that. Additionally they could expose some other details of software implementation of the system, which is not public now.

You did a good job by recreating the messages out of my code, and this is exactly what I expected from users of my code. Would be nice if you would like to contribute to my repository by submitting Pull-Request with your version of messages, so others could profit from that as well. Just drop them maybe in some "msg" folder in the root.

Best regards,
Max.

@ekampourakis
Copy link
Author

Thanks for your quick reply @MaxMagazin ,

I'm currently working on a FS driverless car myself and trying your algorithm for the initial mapping of the track. When I'm done with the testing and the implementation I'll submit a pull request with all my supplementary messages and couple of changes for you to review.

Best regards,
Manos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants