Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application env specification should be a map, not list #705

Open
filippomc opened this issue Sep 6, 2023 · 0 comments
Open

Application env specification should be a map, not list #705

filippomc opened this issue Sep 6, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers scope:deployment

Comments

@filippomc
Copy link
Collaborator

filippomc commented Sep 6, 2023

Currently the application environment can be specified as a list resembling the list on the kubernetes spec

application/myapp/values.yaml

harness:
  env:
    - name: A
      value: avalue
    - name: B
      value: bvalue   

The limitation of using a list is that values cannot be overridden in different environments, so if I want to change the A variable in values-dev.yaml I also have to specify B.

In order to make the change backwards compatible can add a new specification

harness:
  envmap:
     A: avalue
     B: bvalue   
@filippomc filippomc added enhancement New feature or request good first issue Good for newcomers scope:deployment labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers scope:deployment
Projects
None yet
Development

No branches or pull requests

1 participant