From f7a0f105f3ef96c1b65005379425f531de027d08 Mon Sep 17 00:00:00 2001 From: legobt <6wbvkn0j@anonaddy.me> Date: Tue, 13 Aug 2024 01:45:34 +0000 Subject: [PATCH 1/2] feat(getMostRecentTags): add fetchRemote option to allow disabling remote fetching --- src/update-changelog.ts | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/update-changelog.ts b/src/update-changelog.ts index 7bf8ec0..6ae4fce 100644 --- a/src/update-changelog.ts +++ b/src/update-changelog.ts @@ -11,17 +11,25 @@ import { PackageRename } from './shared-types'; * Get the most recent tag for a project. * * @param options - Options. + * @param options.fetchRemote - Whether to synchronize local tags with remote. * @param options.tagPrefixes - A list of tag prefixes to look for, where the first is the intended * prefix and each subsequent prefix is a fallback in case the previous tag prefixes are not found. + * @param options.run - Optional alternative shell command interpreter * @returns The most recent tag. */ async function getMostRecentTag({ + fetchRemote, tagPrefixes, + run = runCommand, }: { + fetchRemote?: boolean; tagPrefixes: [string, ...string[]]; + run?: (cmd: string, args: string[]) => Promise<(string|null)[]>; }) { // Ensure we have all tags on remote - await runCommand('git', ['fetch', '--tags']); + if (typeof fetchRemote !== 'boolean' || fetchRemote) { + await run('git', ['fetch', '--tags']); + } let mostRecentTagCommitHash: string | null = null; for (const tagPrefix of tagPrefixes) { @@ -219,6 +227,8 @@ export type UpdateChangelogOptions = { * The package rename properties, used in case of package is renamed */ packageRename?: PackageRename; + fetchRemote?: boolean; + run?: (cmd: string, args: string[]) => Promise<(string|null)[]>; }; /** @@ -243,6 +253,8 @@ export type UpdateChangelogOptions = { * @param options.formatter - A custom Markdown formatter to use. * @param options.packageRename - The package rename properties. * An optional, which is required only in case of package renamed. + * @param options.fetchRemote - Whether to synchronize local tags with remote. + * @param options.run - Optional alternative shell command interpreter * @returns The updated changelog text. */ export async function updateChangelog({ @@ -254,6 +266,8 @@ export async function updateChangelog({ tagPrefixes = ['v'], formatter = undefined, packageRename, + fetchRemote = true, + run, }: UpdateChangelogOptions): Promise { const changelog = parseChangelog({ changelogContent, @@ -264,6 +278,8 @@ export async function updateChangelog({ }); const mostRecentTag = await getMostRecentTag({ + fetchRemote, + run, tagPrefixes, }); From 091dd8d406b123010fb34c2aa4180bef5ac17ddd Mon Sep 17 00:00:00 2001 From: legobt <6wbvkn0j@anonaddy.me> Date: Tue, 29 Oct 2024 03:58:14 +0000 Subject: [PATCH 2/2] chore: add test for updateChangelog --- src/update-changelog.test.ts | 51 ++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 src/update-changelog.test.ts diff --git a/src/update-changelog.test.ts b/src/update-changelog.test.ts new file mode 100644 index 0000000..d4b27fd --- /dev/null +++ b/src/update-changelog.test.ts @@ -0,0 +1,51 @@ +import _outdent from 'outdent'; + +import { updateChangelog } from './update-changelog'; + +const outdent = _outdent({ trimTrailingNewline: false }); + +describe('updateChangelog', () => { + it('should call git fetch by default', () => { + const cmdMock = jest.fn(); + updateChangelog({ + changelogContent: outdent` + # Changelog + All notable changes to this project will be documented in this file. + + The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), + and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). + + ## [Unreleased] + + [Unreleased]:https://github.com/ExampleUsernameOrOrganization/ExampleRepository/ + `, + isReleaseCandidate: true, + repoUrl: + 'https://github.com/ExampleUsernameOrOrganization/ExampleRepository', + run: cmdMock, + }); + expect(cmdMock).toHaveBeenCalledWith('git', ['fetch', '--tags']) + }); + it('should not call git fetch when ', () => { + const cmdMock = jest.fn(); + updateChangelog({ + changelogContent: outdent` + # Changelog + All notable changes to this project will be documented in this file. + + The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), + and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). + + ## [Unreleased] + + [Unreleased]:https://github.com/ExampleUsernameOrOrganization/ExampleRepository/ + `, + isReleaseCandidate: true, + repoUrl: + 'https://github.com/ExampleUsernameOrOrganization/ExampleRepository', + fetchRemote: false, + run: cmdMock, + }); + expect(cmdMock).not.toHaveBeenCalledWith(['git'], ['fetch', '--tags']) + }); +});