Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TypeScript Best Practices and style guide #4

Open
brad-decker opened this issue Mar 21, 2022 · 2 comments
Open

Create TypeScript Best Practices and style guide #4

brad-decker opened this issue Mar 21, 2022 · 2 comments
Assignees

Comments

@brad-decker
Copy link
Contributor

This document, which will apply to both mobile and extension (and any repository, future or present), must be ratified by members of all product teams. It should detail our best practices when using TypeScript, including configuration, code examples, etc. In addition we should include a full style guide, using our eslint configuration as the base. The eslint configuration for typescript codifies our style guide and pulling in the rules and writing examples in the style guide will help to prepare the extension for typescript refactor.

@mcmire mcmire self-assigned this Jul 19, 2023
@mcmire
Copy link
Contributor

mcmire commented Jul 19, 2023

The Shared Libraries team will take on an initial version of this document. It should be located in the "Standards" directory.

@mcmire
Copy link
Contributor

mcmire commented Aug 2, 2023

We have begun a document for TypeScript guidelines, but we've intentionally left it incomplete for now. We will likely not have time this quarter to continue adding to it, so I am taking it out of our product backlog. That said, others are free to add more guidelines as they see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants