From f5a6dc5edfd32e99bcdd68c9baa21d687fd1ba4b Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Wed, 4 Oct 2023 11:17:18 -0600 Subject: [PATCH] Add missing changelog entries - Add changelog entries for transaction-controller - Bump transaction-controller to 14.0.0 - Add changelog entries for assets-controllers --- packages/assets-controllers/CHANGELOG.md | 45 +++++++++++--------- packages/transaction-controller/CHANGELOG.md | 24 +++++++++-- packages/transaction-controller/package.json | 2 +- 3 files changed, 46 insertions(+), 25 deletions(-) diff --git a/packages/assets-controllers/CHANGELOG.md b/packages/assets-controllers/CHANGELOG.md index 7aaa47fb84..7244342b43 100644 --- a/packages/assets-controllers/CHANGELOG.md +++ b/packages/assets-controllers/CHANGELOG.md @@ -9,40 +9,43 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [15.0.0] ### Changed - **BREAKING**: `NftController` now expects `getNetworkClientById` in constructor options ([#1698](https://github.com/MetaMask/core/pull/1698)) -- **BREAKING**: `NftController.addNft()` function signature has changed ([#1698](https://github.com/MetaMask/core/pull/1698)) +- **BREAKING**: `NftController.addNft` function signature has changed ([#1698](https://github.com/MetaMask/core/pull/1698)) - Previously ``` - address: string, - tokenId: string, - nftMetadata?: NftMetadata, - accountParams?: { - userAddress: string; - chainId: Hex; - }, - source = Source.Custom, + address: string, + tokenId: string, + nftMetadata?: NftMetadata, + accountParams?: { + userAddress: string; + chainId: Hex; + }, + source = Source.Custom, ``` - now: + now: ``` - tokenAddress: string, - tokenId: string, - { - nftMetadata?: NftMetadata; - chainId?: Hex; // extracts from AccountParams - userAddress?: string // extracted from AccountParams - source?: Source; - networkClientId?: NetworkClientId; // new - }, + tokenAddress: string, + tokenId: string, + { + nftMetadata?: NftMetadata; + chainId?: Hex; // extracts from AccountParams + userAddress?: string // extracted from AccountParams + source?: Source; + networkClientId?: NetworkClientId; // new + }, ``` - `NftController.addNftVerifyOwnership`: Now accepts optional 3rd argument `networkClientId` which is used to fetch NFT metadata and determine by which chainId the added NFT should be stored in state. Also accepts optional 4th argument `source` used for metrics to identify the flow in which the NFT was added to the wallet. ([#1698](https://github.com/MetaMask/core/pull/1698)) - `NftController.isNftOwner`: Now accepts optional `networkClientId` which is used to instantiate the provider for the correct chain and call the NFT contract to verify ownership ([#1698](https://github.com/MetaMask/core/pull/1698)) -- `NftController.addNft()` will use the chainId value derived from `networkClientId` if provided ([#1698](https://github.com/MetaMask/core/pull/1698)) -- `NftController.watchNft()` options now accepts optional `networkClientId` which is used to fetch NFT metadata and determine by which chainId the added NFT should be stored in state ([#1698](https://github.com/MetaMask/core/pull/1698)) +- `NftController.addNft` will use the chainId value derived from `networkClientId` if provided ([#1698](https://github.com/MetaMask/core/pull/1698)) +- `NftController.watchNft` options now accepts optional `networkClientId` which is used to fetch NFT metadata and determine by which chainId the added NFT should be stored in state ([#1698](https://github.com/MetaMask/core/pull/1698)) - Bump dependency on `@metamask/utils` to ^8.1.0 ([#1639](https://github.com/MetaMask/core/pull/1639)) - Bump dependency and peer dependency on `@metamask/approval-controller` to ^4.0.0 - Bump dependency on `@metamask/base-controller` to ^3.2.3 - Bump dependency on `@metamask/controller-utils` to ^5.0.2 - Bump dependency and peer dependency on `@metamask/network-controller` to ^14.0.0 +### Fixed +- Fix bug in TokensController where batched `addToken` overwrote each other because mutex was acquired after reading state ([#1768](https://github.com/MetaMask/core/pull/1768)) + ## [14.0.0] ### Changed - Update TypeScript to v4.8.x ([#1718](https://github.com/MetaMask/core/pull/1718)) diff --git a/packages/transaction-controller/CHANGELOG.md b/packages/transaction-controller/CHANGELOG.md index e01fae5132..d0669a7884 100644 --- a/packages/transaction-controller/CHANGELOG.md +++ b/packages/transaction-controller/CHANGELOG.md @@ -6,7 +6,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -## [13.0.1] +## [14.0.0] +### Added +- **BREAKING:** Add required `getPermittedAccounts` argument to constructor, used to validate `from` addresses ([#1722](https://github.com/MetaMask/core/pull/1722)) +- Add `securityProviderRequest` option to constructor ([#1725](https://github.com/MetaMask/core/pull/1725)) +- Add `method` option to `addTransaction` method ([#1725](https://github.com/MetaMask/core/pull/1725)) +- Add `securityProviderRequest` property to TransactionMetaBase ([#1725](https://github.com/MetaMask/core/pull/1725)) +- Add SecurityProviderRequest type ([#1725](https://github.com/MetaMask/core/pull/1725)) +- Update `addTransaction` to set `securityProviderRequest` on transaction metadata when requested to do so ([#1725](https://github.com/MetaMask/core/pull/1725)) +- Update `txParams` validation to validate `chainId` ([#1723](https://github.com/MetaMask/core/pull/1723)) +- Update `addTransaction` to ensure allowed `from` address when `origin` is specified ([#1722](https://github.com/MetaMask/core/pull/1722)) + ### Changed - Bump dependency on `@metamask/utils` to ^8.1.0 ([#1639](https://github.com/MetaMask/core/pull/1639)) - Bump dependency and peer dependency on `@metamask/approval-controller` to ^4.0.0 @@ -14,6 +24,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Bump dependency on `@metamask/controller-utils` to ^5.0.2 - Bump dependency and peer dependency on `@metamask/network-controller` to ^14.0.0 +### Removed +- **BREAKING:** Remove `interval` config option ([#1746](https://github.com/MetaMask/core/pull/1746)) + - The block tracker (which has its own interval) is now used to poll for pending transactions instead. +- **BREAKING:** Remove `poll` method ([#1746](https://github.com/MetaMask/core/pull/1746)) + - The block tracker is assumed to be running, TransactionController does not offer a way to stop it. +- **BREAKING:** Remove `queryTransactionStatuses` method ([#1746](https://github.com/MetaMask/core/pull/1746)) + - This functionality has been moved to a private interface and there is no way to use it externally. + ## [13.0.0] ### Changed - **BREAKING**: Add required `getCurrentAccountEIP1559Compatibility` and `getCurrentNetworkEIP1559Compatibility` callback arguments to constructor ([#1693](https://github.com/MetaMask/core/pull/1693)) @@ -219,8 +237,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 All changes listed after this point were applied to this package following the monorepo conversion. -[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@13.0.1...HEAD -[13.0.1]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@13.0.0...@metamask/transaction-controller@13.0.1 +[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@14.0.0...HEAD +[14.0.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@13.0.0...@metamask/transaction-controller@14.0.0 [13.0.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@12.0.0...@metamask/transaction-controller@13.0.0 [12.0.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@11.1.0...@metamask/transaction-controller@12.0.0 [11.1.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@11.0.0...@metamask/transaction-controller@11.1.0 diff --git a/packages/transaction-controller/package.json b/packages/transaction-controller/package.json index eaf4c6b9f4..d6c50965c1 100644 --- a/packages/transaction-controller/package.json +++ b/packages/transaction-controller/package.json @@ -1,6 +1,6 @@ { "name": "@metamask/transaction-controller", - "version": "13.0.1", + "version": "14.0.0", "description": "Stores transactions alongside their periodically updated statuses and manages interactions such as approval and cancellation", "keywords": [ "MetaMask",