Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preferences-controller: moved keyring controller to runtime dependency #4479

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

preferences-controller: moved keyring controller to runtime dependency #4479

wants to merge 1 commit into from

Conversation

kanthesha
Copy link
Contributor

Explanation

@metamask/keyring-controller should be a runtime dependency, not a development dependency.
It's already a peer dependency, so it should be a runtime dependency too.

References

Changelog

@metamask/preferences-controller

  • FIXED: Moved @metamask/keyring-controller from devDependency to runtime dependency

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@kanthesha kanthesha marked this pull request as ready for review June 28, 2024 10:42
@kanthesha kanthesha requested a review from a team as a code owner June 28, 2024 10:42
@Gudahtt
Copy link
Member

Gudahtt commented Jun 28, 2024

It's already a peer dependency, so it should be a runtime dependency too

The opposite is true; a peer dependency should never be a dependency. If we're listing it as a peer dependency, it means that we don't know which version is needed to use the package correctly, so we cannot include it as a regular dependency.

@kanthesha kanthesha marked this pull request as draft June 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kanthesha @Gudahtt